Re: Does NeedsRunner work on parameterized tests?

2018-12-18 Thread Reuven Lax
This is a long-standing JUnit bug, and I suspect these tests have never run. I've tested JUnit 4.13-beta1, and it partially fixes the issue. Parameterized tests now work as long as the include category is set on the entire test class. However individual methods marked with the category are still n

Re: [RFC] I made a new tabbed Beam view in Jenkins

2018-12-18 Thread Mark Liu
That looks great. Thank you! Mark On Tue, Dec 18, 2018 at 1:53 PM Jason Kuster wrote: > Oh, a good fact! Thanks for the info. :) > > On Tue, Dec 18, 2018 at 1:48 PM Alan Myrvold wrote: > >> The _Cron variants of pre-commits are run post-commit, to make it easier >> to tell if the pre-commit is

Re: [RFC] I made a new tabbed Beam view in Jenkins

2018-12-18 Thread Jason Kuster
Oh, a good fact! Thanks for the info. :) On Tue, Dec 18, 2018 at 1:48 PM Alan Myrvold wrote: > The _Cron variants of pre-commits are run post-commit, to make it easier > to tell if the pre-commit is flaky or broken. > > On Tue, Dec 18, 2018 at 1:40 PM Jason Kuster > wrote: > >> This looks great

Re: [RFC] I made a new tabbed Beam view in Jenkins

2018-12-18 Thread Alan Myrvold
The _Cron variants of pre-commits are run post-commit, to make it easier to tell if the pre-commit is flaky or broken. On Tue, Dec 18, 2018 at 1:40 PM Jason Kuster wrote: > This looks great! (also it looks like some precommits snuck into the > postcommit view) > > On Tue, Dec 18, 2018 at 1:25 PM

Re: [RFC] I made a new tabbed Beam view in Jenkins

2018-12-18 Thread Jason Kuster
This looks great! (also it looks like some precommits snuck into the postcommit view) On Tue, Dec 18, 2018 at 1:25 PM Alan Myrvold wrote: > It does look much better! > > On Tue, Dec 18, 2018 at 1:10 PM Ahmet Altay wrote: > >> I like this version, it looks cleaner than the current combined view.

Re: [RFC] I made a new tabbed Beam view in Jenkins

2018-12-18 Thread Alan Myrvold
It does look much better! On Tue, Dec 18, 2018 at 1:10 PM Ahmet Altay wrote: > I like this version, it looks cleaner than the current combined view. > > On Tue, Dec 18, 2018 at 12:53 PM Scott Wegner wrote: > >> Very cool. I also didn't realize we had control over the Jenkins "views". >> >> We c

Re: [RFC] I made a new tabbed Beam view in Jenkins

2018-12-18 Thread Ahmet Altay
I like this version, it looks cleaner than the current combined view. On Tue, Dec 18, 2018 at 12:53 PM Scott Wegner wrote: > Very cool. I also didn't realize we had control over the Jenkins "views". > > We currently lack a decent dashboard to monitor the build health across > Beam jenkins jobs a

Re: [RFC] I made a new tabbed Beam view in Jenkins

2018-12-18 Thread Scott Wegner
Very cool. I also didn't realize we had control over the Jenkins "views". We currently lack a decent dashboard to monitor the build health across Beam jenkins jobs and triage failures; this is a step in the right direction. I haven't played with Jenkins views before, but it appears they can be ma

Re: [RFC] I made a new tabbed Beam view in Jenkins

2018-12-18 Thread Anton Kedin
This is really helpful, didn't realize it was possible. Categories and contents look reasonable. I think something like this definitely should be the top-level Beam view. Regards, Anton On Tue, Dec 18, 2018 at 12:05 PM Kenneth Knowles wrote: > Hi all, > > I made a new view to split Beam builds

[RFC] I made a new tabbed Beam view in Jenkins

2018-12-18 Thread Kenneth Knowles
Hi all, I made a new view to split Beam builds into tabs: https://builds.apache.org/view/A-D/view/Beam%20Nested/ - PostCommit tab includes PostCommit and "PreCommit_.*_Cron" because these are actually post-commit jobs; it is a feature not a bug. - PreCommit tab includes jobs that have no meanin

Re: Does NeedsRunner work on parameterized tests?

2018-12-18 Thread Kenneth Knowles
Upon digging in, it appears to be a JUnit issue. Did it ever work? The includes/excludes are passed along from Gradle to JUnit. Fixed in the as-yet-still-beta 4.13 (notably in RC stages since Feb, and declared to be the last release of JUnit 4). Kenn On Tue, Dec 18, 2018 at 12:45 PM Scott Wegner

Re: Build failed in Jenkins: beam_SeedJob_Standalone #2081

2018-12-18 Thread Scott Wegner
Yes, sorry for the noise. I'm currently investigating this. Tracking via BEAM-6250. See: https://lists.apache.org/thread.html/f9beb16bd4a6627338812870731d8975792effbbc43e2973c2ee4b5d@%3Cdev.beam.apache.org%3E On Tue, Dec 18, 2018 at 9:20 AM Kenneth Knowles wrote: > This has been happening reli

Re: Does NeedsRunner work on parameterized tests?

2018-12-18 Thread Scott Wegner
We hit a similar issue when trying to refactor some tests to use the 'Enclosed' runner. It seems the Gradle test filtering is not compatible with the Enclosed runner See BEAM-4375 [1] and pr/5440 [2]. I'm not familiar with the Parametrized runner, but perhaps it has similar issues. [1] https://is

Fwd: Build failed in Jenkins: beam_SeedJob_Standalone #2081

2018-12-18 Thread Kenneth Knowles
This has been happening reliably since https://builds.apache.org/blue/organizations/jenkins/beam_SeedJob_Standalone/detail/beam_SeedJob_Standalone/2063/changes I'm guessing it has to do with removing _GradleBuild from the names, but haven't looked more deeply. For context: this is a fork of the s

Re: [Fwd: [Apache Beam] Custom DataSourceV2 instanciation: parameters passing and Encoders]

2018-12-18 Thread Kenneth Knowles
I don't know DataSourceV2 well, but I am reading around to try to help. I see the problem with the SparkSession API. Is there no other way to instantiate a DataSourceV2 and read the data from it? Other thoughts: - Maybe start from Splittable DoFn since it is a new translator? - I wonder if the

Re: [Fwd: [Apache Beam] Custom DataSourceV2 instanciation: parameters passing and Encoders]

2018-12-18 Thread Etienne Chauchot
Hi everyone, Does anyone have comments on this question? ThanksEtienne Le vendredi 14 décembre 2018 à 10:37 +0100, Etienne Chauchot a écrit : > Hi guys,I'm currently coding a POC on a new spark runner based on structured > streaming and new DataSourceV2 API and > I'm having an interrogation. Hav

Re: Visual Beam Development w/ Kettle

2018-12-18 Thread Maximilian Michels
+1 for advertising the integration. I suppose this could go into the "Community" tab of the website? Here's a draft: https://github.com/apache/beam/pull/7308 -Max On 17.12.18 17:35, Kenneth Knowles wrote: +dev@: It would be nice to link to such integrations from the Beam site. I don't think w