Re: Reviews of pull requests

2022-11-16 Thread Bertrand Delacretaz
Hi, Josh Fischer wrote: > ...I do find it helpful if I leave a PR open for 12-24 > hours to people a chance to make any comments before we merge... +1, that's a great way of "radiating intent" [1], leaving a chance for others to object without slowing down too much. -Bertrand [1] https://medi

Re: Reviews of pull requests

2022-11-16 Thread Bertil Chapuis
Thanks a lot for all your feedback. Josh, your idea is balanced. Opening the PR and tagging reviewers leaves the opportunity to comment or to object to a change. The branch protection rules have been disabled. Bertil > On 16 Nov 2022, at 09:33, Bertrand Delacretaz wrote: > > Hi, > > Josh Fi

baremaps.apache.org ?

2022-11-16 Thread Bertrand Delacretaz
Hi, It looks like Bertil made all the necessary changes to activate the website publishing, and https://github.com/apache/incubator-baremaps/deployments seems to confirm that it is happening and github-pages deployments there correctly point to https://baremaps.apache.org/ However https://baremap

Re: baremaps.apache.org ?

2022-11-16 Thread Bertil Chapuis
I opened an ticket to track this issue: https://issues.apache.org/jira/browse/INFRA-23911 I’m not completely sure to understand the second point in the answer quoted here: - The CNAME file must be in the root of the repo, not inside the docs directory. - You cannot choose baremaps.apache.org as t

Re: baremaps.apache.org ?

2022-11-16 Thread Bertil Chapuis
Moving the Web site in a separate repository may be an option to consider, as it is closer to what the documentation recommends. > On 16 Nov 2022, at 16:28, Bertil Chapuis wrote: > > I opened an ticket to track this issue: > https://issues.apache.org/jira/browse/INFRA-23911 > > I’m not comple

Re: baremaps.apache.org ?

2022-11-16 Thread Bertrand Delacretaz
Bertil Chapuis wrote: > ...Moving the Web site in a separate repository may be an option to consider, > as it is closer to what the documentation recommends... +1, and that can also make it easier for docs-only contributors to jump in, and the build cycles of both repositories are completely unr

Re: baremaps.apache.org ?

2022-11-16 Thread Bertil Chapuis
The website is published with a separate repository: https://github.com/apache/incubator-baremaps-site We now need to make it conform to Apache’s standards. Here is the issue to track progress on the necessary changes: https://github.com/apache/incubator-baremaps/issues/489 In addition all the e

Re: Reviews of pull requests

2022-11-16 Thread Andrea Borghi
I agree with the fact that ctr can be a very effective way of pushing forward. Ok for me to allow it, it is then to the pr author to consider when he feels that a review is required before merging. I'm really not used to this way, it will be interesting to see how this performs ;) Andrea On Wed,

Re: Reviews of pull requests

2022-11-16 Thread Josh Fischer
Bertrand, Thank you for the article. I’ve never heard this term before. My favorite bullet point from the first article is: - Radiating intent shows others that adventurous behavior is acceptable in the org. I learned something new today. +1 to you, sir. On Wed, Nov 16, 2022 at 4:3