Re: Reviews of pull requests

2022-11-15 Thread Bertrand Delacretaz
Hi, Bertil Chapuis wrote: > ...Do you think we should relax the current policy and disable the review > requirement?... I think it's good for the project to define whether it wants to operate in CTR or RTC mode (Commit-Then-Review or Review-Then-Commit, [1]) IMO declaring CTR generally (which

Re: Reviews of pull requests

2022-11-15 Thread Bertil Chapuis
Thank you Andrea and Bertrand for your answers. I agree with you Andrea, it is a good practice to have several people reviewing PRs. The problem right now is that a lot of small changes are required to make progress on the first release. Some of these changes need to be in main in order to be t

Re: Reviews of pull requests

2022-11-15 Thread Julian Hyde
The "CTR vs RTC" discussion is an important one for a community to have. In my opinion, there's no easy answer. (I'm basically agreeing with Bertrand here.) It is certainly useful to have a default process, and that default process should probably be RTC. But also develop trust so that people who h

Re: Reviews of pull requests

2022-11-15 Thread Josh Fischer
I’m fine either way. I do find it helpful if I leave a PR open for 12-24 hours to people a chance to make any comments before we merge. But then again waiting can be a bit progress killer at times. On Tue, Nov 15, 2022 at 2:16 PM Julian Hyde wrote: > The "CTR vs RTC" discussion is an importa