Re: [VOTE] Release Apache Avro 1.11.1 RC1

2022-07-27 Thread Christophe Le Saëc
Another +1 to release ! Le mer. 27 juil. 2022 à 09:55, Martin Grigorov a écrit : > +1 to release ! > > On Tue, Jul 26, 2022 at 11:36 PM Ryan Skraba wrote: > > > Hi everyone, > > > > I'd like to propose the following RC1 to be released as the official > Apache > > Avro 1.11.1 release. > > > > Th

Re: Supporting unicode named fields

2022-09-01 Thread Christophe Le Saëc
Current java code already accept Unicode char, i added a unit test to show it . It accepts Japanese and Chinese name, that match our needs, but as it's not

Avro Java Version

2022-09-09 Thread Christophe Le Saëc
version with Maven trick). Whole unit tests work fine. I wonder if there are other good reasons to stay with Java 8 version. Best regards, Christophe Le Saëc

Re: Avro Java Version

2022-09-12 Thread Christophe Le Saëc
ip to determine which versions of python we > > support. > > > > I created https://issues.apache.org/jira/browse/AVRO-3627 to make sure > > this gets tracked one day for easy reference! > > > > All my best, Ryan > > > > [1]: > > > https://githu

Re: Avro Java Version

2022-09-12 Thread Christophe Le Saëc
be we should be prepared to maintain 1.11.x for some more > time ?! > > Martin > > On Mon, Sep 12, 2022 at 10:20 AM Christophe Le Saëc > wrote: > > > @r...@skraba.com > >: Indeed, it seems that lot of Apache commons project are still using > > Java8, for example, Com

Programming languages for Avro

2022-11-08 Thread Christophe Le Saëc
Avro is currently implemented in 10 languages, this leads to some issue : - For a new feature, it's difficult to add it everywhere. - Difficult to ensure that each implementations have same possibilities. - Bug fix can be hard (This JIRA

Re: Programming languages for Avro

2022-11-08 Thread Christophe Le Saëc
- Format schemata into all formats supported for parsing > >- RPC using Avro protocols > >- Parse schemata / protocols from IDL or other formats > >- Generate code from schemata (like SpecificRecord subclasses in Java > >using the Maven or Gradle plugins) &

[DISCUSS][VOTE] Naming rules

2022-11-09 Thread Christophe Le Saëc
Hello community, JIRA ticket AVRO-3532 show the issue. Formal naming rules described in documentation are more restrictives than effective control in Java (And C#). Indeed, java code

Re: [DISCUSS][VOTE] Naming rules

2022-11-15 Thread Christophe Le Saëc
Avro spec, and provide language-specific ways to easily disable > validating names if desired. There's some precedence for this in the > Schema.Parser#validate method. > > There's a bit more going on here that's worth doing right for the future! > > All my best,

Re: [DISCUSS][VOTE] Naming rules

2022-11-25 Thread Christophe Le Saëc
> and projects can count on. > > The configuration approach is one that would allow upstream projects > to continue working with out-of-spec names, while alerting them that > these could cause interoperability problems outside of their current > cases! One thing for certain, the s

Re: [DISCUSS][VOTE] Naming rules

2022-11-28 Thread Christophe Le Saëc
Another point, could we mimic this java rules <https://docs.oracle.com/javase/tutorial/java/nutsandbolts/variables.html> ? (excluding 'dot' and 'space' from names) Le ven. 25 nov. 2022 à 17:28, Christophe Le Saëc a écrit : > Thanks for sharing the url http

Re: Release language modules separately

2023-01-05 Thread Christophe Le Saëc
I'm also in favor of this idea (+1). Just to figure out,*splitting the language SDKs to separate releases and releasing separately.* : Concretely, is this means that there will be one github repo for each language (So 10 avro github repo); or is there any other "github" trick to manage separate rel

Flaky test with TestNettyServer

2023-01-05 Thread Christophe Le Saëc
Hello, On my PRs, i have sometimes an error on TestNettyServer unit test Error: org.apache.avro.ipc.netty.TestNettyServer.connectionsCount Time elapsed: 0.008 s <<<

Re: Release language modules separately

2023-01-05 Thread Christophe Le Saëc
👍 Le jeu. 5 janv. 2023 à 13:58, Martin Grigorov a écrit : > Hi, > > On Thu, Jan 5, 2023 at 2:40 PM Christophe Le Saëc > wrote: > > > I'm also in favor of this idea (+1). > > Just to figure out,*splitting the language SDKs to separate releases and > > r

Question about CodeQL in Java

2023-01-08 Thread Christophe Le Saëc
Hello, Code QL complains here about one of my PR : *Class RecordSchema overrides but not hashCode*. But, this is still the case on master (equals is redefine for RecordSchema class, and not hashCode, while this is computeHas

Re: Question about CodeQL in Java

2023-01-10 Thread Christophe Le Saëc
lue to solve it ? or do we have to apply same kind of strategy for equals ? Le lun. 9 janv. 2023 à 08:44, Christophe Le Saëc a écrit : > Hello, > Code QL complains here > <https://github.com/apache/avro/pull/1776/checks?check_run_id=10481957660> > about one of my PR : *Cla

Re: Release language modules separately

2023-01-12 Thread Christophe Le Saëc
With one github repo; how to manage share folder ? i mean if one version need updates on this repo but not the older. As an example, this JIRA AVRO-3591 aims to create commons inter sdk unit tests

Re: Release language modules separately

2023-01-12 Thread Christophe Le Saëc
share/11 ... ? Le jeu. 12 janv. 2023 à 15:19, Martin Grigorov a écrit : > On Thu, Jan 12, 2023 at 3:12 PM Christophe Le Saëc > wrote: > > > With one github repo; how to manage share > > <https://github.com/apache/avro/tree/master/share> folder ? i mean if > one >

Re: Release language modules separately

2023-01-13 Thread Christophe Le Saëc
ears on github) Le jeu. 12 janv. 2023 à 17:53, Martin Grigorov a écrit : > On Thu, Jan 12, 2023, 17:33 Christophe Le Saëc wrote: > > > So, if i take the latest one; i could have > > lang/java 13.1 > > lang/python 11.2 > > lang/rust 12.3 > > > > So what w

Re: [AVRO-3713] Why does the default values cache need weak keys?

2023-02-13 Thread Christophe Le Saëc
Hi Niels, I think WeakHashMap is used because it's onwed by GenericData which is a singleton. So, Fields should be "weak reference" to allow garbaging when field is removed. As comment says // this MAY result in two threads creating the same defaultValue // and calling put. The last thread will w

Re: [DISCUSS] Java 8 compatibility?

2023-03-09 Thread Christophe Le Saëc
ture "major" version in Java 11 or 17 only is not a pb i think. Best regards, Christophe Le Saëc Le mer. 8 mars 2023 à 23:22, Niels Basjes a écrit : > Hi, > > I was looking into making the build run in only Java 11 or 17 because there > are more and more maven plugins that

Re: [JAVA] Proposal: Dropping theUnsafe

2023-05-05 Thread Christophe Le Saëc
Hello Niels, This is a nice idea !! In same spirit, few time ago, i wrote class FieldAccessHandle (see joined file), another extension of FieldAccess, that use "java.lang.invoke.MethodHandle" instead of Unsafe. And change ReflectionUtil class with it final FieldAccess unsafeAccess;

Re: [JAVA] Proposal: Dropping theUnsafe

2023-05-05 Thread Christophe Le Saëc
As far as i understood, MethodHandle is design to replace Unsafe call If not, forget my first message. Le ven. 5 mai 2023 à 14:37, Oscar Westra van Holthe - Kind < os...@westravanholthe.nl> a écrit : > Hi Niels, > > T

Re: [JAVA] Proposal: Dropping theUnsafe

2023-05-09 Thread Christophe Le Saëc
IVE-22415> are > still not on Java11. Related to this, I also opened up a PR to bring back > Java 8 support for Thrift <https://github.com/apache/thrift/pull/2785>, I > don't think that we can drop this soon. > > Kind regards, > Fokko Driesprong > > > Op v

Checks on Avro PR

2023-06-21 Thread Christophe Le Saëc
Hello Avro developpers, A question on Avro Github Pull Request; since few weeks, i have some Java PR, as this one , where checks limits to "*Pull Request Labeler / triage (pull_request_target)"*, and no compile/test are done. Others PR, as this

Re: Checks on Avro PR

2023-06-22 Thread Christophe Le Saëc
wn* repo and run the CI personally! Can you > give this a try and report if it works for you? > > All my best regards, Ryan > > > On Wed, Jun 21, 2023 at 4:42 PM Christophe Le Saëc > wrote: > > > > Hello Avro developpers, > > > > A question on Avro Githu

Re: [VOTE] Release Apache Avro 1.11.2 RC1

2023-07-05 Thread Christophe Le Saëc
Felix Krull just found this issue in Java vresion (with the PR to fix). So, as a regression, IMHO it should be merged before 1.11.2 release ? Le mer. 5 juil. 2023 à 14:55, Martin Grigorov a écrit : > Hi, > > Sorry for the late reply! I was on vac

Re: [DISCUSS] Release Avro 1.11.3

2023-07-12 Thread Christophe Le Saëc
+1 for me too. (*Are votes reserved for commiters or PMC ?*) Le mer. 12 juil. 2023 à 13:38, Martin Grigorov a écrit : > +1 from me ! > > On Wed, Jul 12, 2023 at 2:34 PM Ryan Skraba wrote: > > > The regression from AVRO-3789 looks like it a sufficient regression to > > merit releasing 1.11.3, wh

Re: [DISCUSS] Release maintenance and lifecycle

2023-07-18 Thread Christophe Le Saëc
Hello I find this proposal relevant. to clarify : > From 1.12.0 on, I'd like to propose maintaining *two* major versions > (i.e. 1.12.x and 1.11.x). That would allow us to deprecate and modify > APIs and give developers one whole major release to switch. this means to maintain 3 branches (1.13.

Generated code breaking change

2023-08-10 Thread Christophe Le Saëc
Hello, I've made this PR to fix a bug describe in this JIRA that describe some case, when schema contains fields with similar names (and some start with '_') and generated code can't compile because some m

Fwd: Generated code breaking change

2023-08-16 Thread Christophe Le Saëc
- De : Martin Grigorov Date: ven. 11 août 2023 à 12:40 Subject: Re: Generated code breaking change To: On Thu, Aug 10, 2023 at 6:17 PM Oscar Westra van Holthe - Kind < os...@westravanholthe.nl> wrote: > On Thu, 10 Aug 2023 at 15:30, Christophe Le Saëc > wrote: > > >

Re: Generated code breaking change

2023-08-18 Thread Christophe Le Saëc
PR is now merged Le jeu. 17 août 2023 à 08:58, Christophe Le Saëc a écrit : > > So, if there is no objection on this breaking (see AVRO-3749 > <https://issues.apache.org/jira/browse/AVRO-3749>) change on generated > code, i will merge this PR <https://github.com/apache

Re: [VOTE] Release Apache Avro 1.11.3 RC1

2023-09-18 Thread Christophe Le Saëc
+1 Le dim. 17 sept. 2023 à 10:40, Ryan Skraba a écrit : > Hi everyone, > > I'd like to propose the following RC1 to be released as the official Apache > Avro 1.11.3 release. > > The commit id is 35ff8b997738e4d983871902d47bfb67b3250734 > * This corresponds to the tag: release-1.11.3-rc1 > * http

New Big Decimal Logical type

2023-09-18 Thread Christophe Le Saëc
Hello, This JIRA ticket would introduce a new Big-Decimal logical type where precision and scale are not given in the type definition, all is embedded in the value (this new logical type does not replace current one). This is useful when you need b

Re: [ANNOUNCE] New committer: Christophe Le Saec

2023-09-21 Thread Christophe Le Saëc
Thank you !! Glad to be a part of the team. Le jeu. 21 sept. 2023 à 08:55, Martin Grigorov a écrit : > Welcome to the team, Christophe! > > On Wed, Sep 20, 2023 at 9:00 PM Ryan Skraba wrote: > > > The Project Management Committee (PMC) for Apache Avro has invited > > Christophe Le Saec to becom

Re: New Big Decimal Logical type

2023-09-21 Thread Christophe Le Saëc
ow the precision > of our data yet". As an example, Google Cloud Spanner recommends > using Strings when a predefined precision and scale is unsatisfactory > for a column[1]. Is there a better way for us to help the use when > they don't know the precision of data they expe

Re: New Big Decimal Logical type

2023-09-27 Thread Christophe Le Saëc
*schema evolution on logical types* : Sounds like a good idea for a future new feature. *stringable representation of BigDecimal* : That's indeed not the case even with current decimal type. This could be added with fromCharSequence/toCharSequence with current and new decimal type to get exponenti

[Discuss] Schema inheritance

2023-12-15 Thread Christophe Le Saëc
Hello, As suggested in this JIRA and this other one , it could be a nice feature in Avro to integrate record schema inheritance. Concretely, a child schema have extra fields compare to its parent, a