Re: Make Apache Avro a proper Java module.

2024-02-12 Thread Martin Grigorov
Hi Chad, Yes! Dropping support for Java 8 is in the talks! We want to release 1.12 with the current changes in the 'main' branch (hopefully in the next few weeks) and then we can drop Java 8 in 'main' that will be Avro 2.0 most likely! You can open a PR for discussion now! But it will be merged on

Re: Make Apache Avro a proper Java module.

2024-02-11 Thread Chad Preisler
Hello, Will Avro be moving ahead with the removal of JDK8? Thanks, Chad On Fri, Feb 2, 2024 at 2:12 PM Chad Preisler wrote: > I created a fork and branch that removes JDK 8 from the build and makes 11 > default. The changes can be seen here: > > https://github.com/cpreisler/avro/tree/remove-j

Re: Make Apache Avro a proper Java module.

2024-02-06 Thread Martin Grigorov
Hi Chad, Please open a Draft PR with your changes! It will be easier to review and comment on it! Thank you! On Fri, Feb 2, 2024 at 10:20 PM Chad Preisler wrote: > I created a fork and branch that removes JDK 8 from the build and makes 11 > default. The changes can be seen here: > > https://git

Re: Make Apache Avro a proper Java module.

2024-02-02 Thread Chad Preisler
I created a fork and branch that removes JDK 8 from the build and makes 11 default. The changes can be seen here: https://github.com/cpreisler/avro/tree/remove-jdk-8 Let me know what if anything you want me to do with this. On Mon, Jan 29, 2024 at 4:19 AM Niels Basjes wrote: > Yes, Dropping t

Re: Make Apache Avro a proper Java module.

2024-01-29 Thread Niels Basjes
Yes, Dropping the runtime support for Java 8 is enough of a reason to bump to AVRO 2.0.0 for me. On Mon, Jan 8, 2024 at 6:09 PM Stephen Kittelson wrote: > More and more libraries these days are dropping support for JDK 8 (at least > Spring Boot 3, Jakarta EE 11, Mockito 5, among others), so I pe

Re: Make Apache Avro a proper Java module.

2024-01-29 Thread Niels Basjes
Hi, I have been working on this one over the holidays: https://github.com/apache/avro/pull/2699 I'm now able to build with Java 21 and still maintain backwards compatibility for the final artifact with Java 8. This also includes running (almost all) tests for the main avro module under all JDKs (

Re: Make Apache Avro a proper Java module.

2024-01-08 Thread Chad Preisler
I can do both depending on the timeline for 1.12.0. If you are cutting a release this week, that probably won't work. I don't think it will take long to switch to JDK 11 as your default, but I'm not familiar with testing changes to the github actions. Basically there will be some learning curve for

Re: Make Apache Avro a proper Java module.

2024-01-08 Thread Ismaël Mejía
+1 to move to Java 11. Most of our downstream projects have moved out of Java 8 and the fact that we are getting behind on our own dependencies is a sign of the current state of the ecosystem. So good to move, and no need to change the full version. 1.12.0 should be good. We should probably tackle

Re: Make Apache Avro a proper Java module.

2024-01-08 Thread Stephen Kittelson
More and more libraries these days are dropping support for JDK 8 (at least Spring Boot 3, Jakarta EE 11, Mockito 5, among others), so I personally think it would be fine to drop support for JDK 8 in 1.12.0, or maybe even bump the Avro release to 2.0.0 with the removal of JDK 8 support? On Mon, Ja

Re: Make Apache Avro a proper Java module.

2024-01-08 Thread Martin Grigorov
Hi, I think this is a good idea! Some PRs (mostly by dependabot) are not merged because Avro needs to be JDK 8 compatible and the dependencies require a newer JDK... I am not sure whether Avro 1.12.0 still needs to be JDK 8 compatible or not. Martin On Sat, Jan 6, 2024 at 5:55 PM Chad Preisler

Make Apache Avro a proper Java module.

2024-01-06 Thread Chad Preisler
Hello, I'm wondering if there is any interest in making Apache Avro a proper Java module? The following changes are required. - Add or generate the module-info.java file. - Change the POM file to build a multi-release jar. - Replace xerial Snappy with Apache commons-compress Snappy (see additiona