Re: [PR] AVRO-3984 [C++] Improve code generated for unions [avro]

2024-08-20 Thread via GitHub
martin-g merged PR #3047: URL: https://github.com/apache/avro/pull/3047 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@avro.apache.org

Re: Status of AVRO-2078 - enforcement of Avro schema resolution rules for Decimal type? (java)

2024-08-20 Thread Oscar Westra van Holthe - Kind
On tue 20 aug. 2024 16:23, Katrin Skoglund wrote: > Ok, just so I understand, you're basically saying that the Parsing > Canonical Form doesn't currently include information on logical types and > that's why it doesn't make sense to merge this now? Correct. Because the logical type info in the

Re: Status of AVRO-2078 - enforcement of Avro schema resolution rules for Decimal type? (java)

2024-08-20 Thread Katrin Skoglund
Thanks for answering Oscar, Ok, just so I understand, you're basically saying that the Parsing Canonical Form doesn't currently include information on logical types and that's why it doesn't make sense to merge this now? Because the logical type info in the writer schema might have been strippe

Re: Status of AVRO-2078 - enforcement of Avro schema resolution rules for Decimal type? (java)

2024-08-20 Thread Oscar Westra van Holthe - Kind
Hi all, With respect to schema evolution, the current rules allow only type changes that have the exact same byte representation, and are guaranteed to fit. Like int->long: thanks to the zigzag encoding, ints and smaller longs are encoded to the same byte sequence. When reading, type evolution is