Re: [PROPOSAL] Changes to the Python BUILD layout

2015-07-31 Thread Jake Farrell
+1 -Jake On Thu, Jul 30, 2015 at 7:24 PM, Kevin Sweeney wrote: > Somewhat complementary work - this change would make the generated packages > equivalent to the ultimate goal of replacing these top-level BUILD files > directly with setup.py files. Users could begin testing deployment with the >

Re: [PROPOSAL] Changes to the Python BUILD layout

2015-07-30 Thread Kevin Sweeney
Posted https://reviews.apache.org/r/36972/ for feedback. On Thu, Jul 30, 2015 at 5:17 PM, Bill Farner wrote: > +1 > > -=Bill > > On Thu, Jul 30, 2015 at 4:24 PM, Kevin Sweeney > > wrote: > > > Somewhat complementary work - this change would make the generated > packages > > equivalent to the ul

Re: [PROPOSAL] Changes to the Python BUILD layout

2015-07-30 Thread Joe Smith
Cool, thanks for thinking this through! Also a +1 > On Jul 30, 2015, at 5:17 PM, Bill Farner wrote: > > +1 > > -=Bill > > On Thu, Jul 30, 2015 at 4:24 PM, Kevin Sweeney > wrote: > >> Somewhat complementary work - this change would make the generated packages >> equivalent to the ultimate go

Re: [PROPOSAL] Changes to the Python BUILD layout

2015-07-30 Thread Bill Farner
+1 -=Bill On Thu, Jul 30, 2015 at 4:24 PM, Kevin Sweeney wrote: > Somewhat complementary work - this change would make the generated packages > equivalent to the ultimate goal of replacing these top-level BUILD files > directly with setup.py files. Users could begin testing deployment with the

Re: [PROPOSAL] Changes to the Python BUILD layout

2015-07-30 Thread Kevin Sweeney
Somewhat complementary work - this change would make the generated packages equivalent to the ultimate goal of replacing these top-level BUILD files directly with setup.py files. Users could begin testing deployment with the pants-generated sdists and seamlessly drop in setup.py-generated replaceme

Re: [PROPOSAL] Changes to the Python BUILD layout

2015-07-30 Thread Bill Farner
We've talked in the past about switching build tools. Just to keep that in context - how would you weigh this effort against a tool change? -=Bill On Thu, Jul 30, 2015 at 4:00 PM, Kevin Sweeney wrote: > I propose a simplification of the Python BUILD layout as follows and a set > of new convent

[PROPOSAL] Changes to the Python BUILD layout

2015-07-30 Thread Kevin Sweeney
I propose a simplification of the Python BUILD layout as follows and a set of new conventions, as follows: 1) 1 BUILD per 3rd level directory. These are currently ``` % find src/main/python -maxdepth 3 -mindepth 3 -type d |while read dirname; do echo $dirname | sed 's@src/main/python/\(.*\)/\(.*\