Re: [C++] Bump required CMake version

2024-12-09 Thread Marcus Hanwell
I would push pretty strongly for 3.25 for the extra features. It would enable much more modern, compact CMake code. On Mon, Dec 9, 2024 at 4:11 PM Sutou Kouhei wrote: > Hi, > > Currently, we require CMake 3.16 or later: > > https://github.com/apache/arrow/blob/e0f8c5e8e6f8b328a997f7e21bc6fd1a01b

[C++] Bump required CMake version

2024-12-09 Thread Sutou Kouhei
Hi, Currently, we require CMake 3.16 or later: https://github.com/apache/arrow/blob/e0f8c5e8e6f8b328a997f7e21bc6fd1a01b3b3fd/cpp/CMakeLists.txt#L18 > cmake_minimum_required(VERSION 3.16) We want to bump required CMake version to use newer features. We can improve our CMake configurations with th

Re: [C++] Bump required CMake version

2024-12-09 Thread Antoine Pitrou
My vote is on CMake 3.25. Best regards Antoine. Le 09/12/2024 à 22:08, Sutou Kouhei a écrit : Hi, Currently, we require CMake 3.16 or later: https://github.com/apache/arrow/blob/e0f8c5e8e6f8b328a997f7e21bc6fd1a01b3b3fd/cpp/CMakeLists.txt#L18 cmake_minimum_required(VERSION 3.16) We want

Re: [C++] Bump required CMake version

2024-12-09 Thread Jacob Wujciak-Jens
+1 on 3.25 Thanks for the summary kou. Am Mo., 9. Dez. 2024 um 23:02 Uhr schrieb Marcus Hanwell : > > I would push pretty strongly for 3.25 for the extra features. It would > enable much more modern, compact CMake code. > > On Mon, Dec 9, 2024 at 4:11 PM Sutou Kouhei wrote: > > > Hi, > > > > Cur

Re: [C++] Bump required CMake version

2024-12-09 Thread Ruoxi Sun
I would +1 on 3.25. Thanks kou for driving this. *Regards,* *Rossi SUN* On Tue, Dec 10, 2024 at 7:41 AM Jacob Wujciak-Jens wrote: > +1 on 3.25 > > Thanks for the summary kou. > > Am Mo., 9. Dez. 2024 um 23:02 Uhr schrieb Marcus Hanwell > : > > > > I would push pretty strongly for 3.25 for the

Re: [C++] Bump required CMake version

2024-12-09 Thread wish maple
+1 on 3.25 Best, Xuwei Fu Ruoxi Sun 于2024年12月10日周二 08:36写道: > I would +1 on 3.25. > > Thanks kou for driving this. > > *Regards,* > *Rossi SUN* > > > On Tue, Dec 10, 2024 at 7:41 AM Jacob Wujciak-Jens > wrote: > > > +1 on 3.25 > > > > Thanks for the summary kou. > > > > Am Mo., 9. Dez. 2024 um