Fix for bug in parquet stream writer

2020-12-28 Thread anders johansson
Hi, When writing to a primitive node of a logical type not supported by converted_type (such as parquet::LogicalType::TimeUnit::NANOS), the error "Column converted type mismatch" is thrown. As I understand it, the converted_type logic is legacy. The problem is solved by removing if (converted_t

Re: Fix for bug in parquet stream writer

2020-12-28 Thread Wes McKinney
hi Anders, would you like to open a Jira issue and submit a PR (with unit test)? On Mon, Dec 28, 2020 at 9:51 AM anders johansson wrote: > > Hi, > > When writing to a primitive node of a logical type not supported by > converted_type (such as parquet::LogicalType::TimeUnit::NANOS), the error > "C

Re: Fix for bug in parquet stream writer

2020-12-28 Thread anders johansson
Hi, Not sure if my fix is a correct or permanent solution, depending on your plan regarding backwards compatibility, etc. Someone with a deeper understanding of how the code works or is supposed to work should probably have a look at it. A temporary workaround is to inherit from StreamWriter and

GitHub Actions are currently blocked

2020-12-28 Thread Neal Richardson
Hi all, It appears that INFRA has decided to block GitHub actions that are not owned by github or apache: https://issues.apache.org/jira/browse/INFRA-21234 This means that none of our C++, Rust, R, or Julia builds are currently running. INFRA seems to have an allowlist, and I have petitioned to h

Re: GitHub Actions are currently blocked

2020-12-28 Thread Jorge Cardoso Leitão
Thank you so much Neal for bringing this up. I was merging PRs without realizing about this change. :/ Fun stuff, great timing with the release coming up. A quick fix for now is to check the corresponding branch on the user's fork. For example, this PR