Re: [Discuss] Should dense union offsets be always increasing?

2020-11-19 Thread Fan Liya
I think the Java implementation is not aligning with the spec, either. IMO, option 2 provides more performance optimization opportunities. However, it may lead to some unexpected behaviors. For example, when we change the value of one slot, the values of several other slots may be changed as well.

[NIGHTLY] Arrow Build Report for Job nightly-2020-11-19-0

2020-11-19 Thread Crossbow
Arrow Build Report for Job nightly-2020-11-19-0 All tasks: https://github.com/ursa-labs/crossbow/branches/all?query=nightly-2020-11-19-0 Failed Tasks: - homebrew-r-autobrew: URL: https://github.com/ursa-labs/crossbow/branches/all?query=nightly-2020-11-19-0-travis-homebrew-r-autobrew - test-

Re: [Discuss] Should dense union offsets be always increasing?

2020-11-19 Thread Micah Kornfield
Last time this was discussed [1] I think we determined the specification was written as intended and Wes mentioned there that he was also weakly supportive of removing the constraint. >From a previous discussion [2], it sounds like users of JS library were explicitly using the "dictionary" feature