Re: Code review tools for Arrow patches

2016-04-25 Thread Todd Lipcon
Using gerrit as an "optional" tool is a bit difficult, because it doesn't know how to handle commits to a repository that it doesn't own. The way we get around the "commit via gerrit" issue in the Kudu podling is to follow the example of AsterixDB. Commits are made using gerrit, but that doesn't a

Re: Code review tools for Arrow patches

2016-04-25 Thread Wes McKinney
hi Todd, This is helpful to know, thank you. As you say, by "optional" what I meant was that code could be optionally reviewed in Gerrit, but then commits would have to be cherry-picked by the committer from the Gerrit git remote. We would continue to accept patches via GitHub pull requests (but f

Re: Code review tools for Arrow patches

2016-04-25 Thread Todd Lipcon
On Mon, Apr 25, 2016 at 12:09 PM, Wes McKinney wrote: > hi Todd, > > This is helpful to know, thank you. As you say, by "optional" what I > meant was that code could be optionally reviewed in Gerrit, but then > commits would have to be cherry-picked by the committer from the > Gerrit git remote.