In my experience, GitHub pull requests are only appropriate for patches
that do not evolve significantly from the first iteration. Changes to
patches frequently cause outstanding points of discussion to be obscured
(the dreaded "comment on an outdated diff").
Rebasing also frequently puts GitHub t
+1 for Gerrit from me too -- we're using it on Kudu and everyone on the
team likes it.
Happy to help admin the server on the gerrit.cloudera.org box which hosts
Kudu and Impala
-Todd
On Fri, Apr 15, 2016 at 8:48 AM, Wes McKinney wrote:
> In my experience, GitHub pull requests are only appropri
It looks like I am going to be a minority opinion here, but I think there
is at least a case to make that pull requests area little easier for
newcomers.
I also have opinions about rebasing branches that are shared publicly or
currently under review. While it isn't often a problem, rebasing often
i
hey Jason,
I have not used Reviewboard, but the problems you are describing are
(AFAICT) not common complaint among Gerrit users. It would be helpful
to hear more from experienced Gerrit users.
Note that my initial request was not "let's choose a tool that is not
GitHub PRs" for code reviews but
Laurent Goujon created ARROW-105:
Summary: Unit tests fail if assertions are disabled
Key: ARROW-105
URL: https://issues.apache.org/jira/browse/ARROW-105
Project: Apache Arrow
Issue Type: Bug
[
https://issues.apache.org/jira/browse/ARROW-105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15243637#comment-15243637
]
Laurent Goujon commented on ARROW-105:
--
{{BaseAllocator.java}} is accessing {{DEBUG_LO
