Re: Update on ARROW-1463 - Request for merging java-vector-refactor into master

2017-11-13 Thread Siddharth Teotia
Sure, no sweat. On Mon, Nov 13, 2017 at 3:50 PM, Bryan Cutler wrote: > Thanks Siddharth, great work! I'd like to run through it a final time and > possibly try out with Spark before merging to master to make sure there > won't be any big issues. Could we set tomorrow EOD as the time as the tim

Re: Update on ARROW-1463 - Request for merging java-vector-refactor into master

2017-11-13 Thread Bryan Cutler
Thanks Siddharth, great work! I'd like to run through it a final time and possibly try out with Spark before merging to master to make sure there won't be any big issues. Could we set tomorrow EOD as the time as the time to merge, unless anything comes up? Thanks, Bryan On Mon, Nov 13, 2017 at

Re: Update on ARROW-1463 - Request for merging java-vector-refactor into master

2017-11-13 Thread Li Jin
Thanks Siddharth. I agree we should start merging refactor branch to master - this will allows us to make further Java changes easier. There are still left items on https://issues.apache.org/jira/browse/ARROW-1463, we can work on those after merging to master. On Mon, Nov 13, 2017 at 5:31 PM, Si

Update on ARROW-1463 - Request for merging java-vector-refactor into master

2017-11-13 Thread Siddharth Teotia
Functional and Performance testing has been completed with Dremio. We have seen overall improvement in TPCH numbers. We had about 8000 regression tests and 12000 unit tests. I would like to start the process of merging java-vector-refactor branch into master. The branch has 2 patches with 95% of c