Re: [ext] Re: language independent representation of filter expressions

2020-07-27 Thread Wes McKinney
ncies between the Gandiva protobuf and how filter > > expressions should be represented, i.e. in the Gandiva protobuf fields are > > typed when I think fields should just contain a field name. > > > > -Original Message- > > From: Jacques Nadeau > > Sent:

Re: [ext] Re: language independent representation of filter expressions

2020-07-24 Thread Jacques Nadeau
lds are > typed when I think fields should just contain a field name. > > -Original Message- > From: Jacques Nadeau > Sent: Thursday, July 23, 2020 10:14 PM > To: dev > Subject: [ext] Re: language independent representation of filter > expressions > > Have you

RE: [ext] Re: language independent representation of filter expressions

2020-07-24 Thread Patrick Pai
typed when I think fields should just contain a field name. -Original Message- From: Jacques Nadeau Sent: Thursday, July 23, 2020 10:14 PM To: dev Subject: [ext] Re: language independent representation of filter expressions Have you tried to use the existing expression representation pro

Re: language independent representation of filter expressions

2020-07-23 Thread Jacques Nadeau
Have you tried to use the existing expression representation provided by Gandiva? What are the issues you've seen with it? On Wed, Jul 22, 2020 at 10:24 AM Patrick Pai wrote: > Hi all, > > After some discussion with Steve, we'd like to propose and get feedback on > an alternative to representing

Re: language independent representation of filter expressions

2020-07-22 Thread Patrick Pai
Hi all, After some discussion with Steve, we'd like to propose and get feedback on an alternative to representing expressions entirely with flatbuffers. To give some context, we thought about how we'd construct flatbuffer expressions in Java or another language if we went down that route. We re

Re: language independent representation of filter expressions

2020-07-13 Thread Antoine Pitrou
On Sat, 11 Jul 2020 09:55:16 -0700 Jacques Nadeau wrote: > > I'm against extending use of flatbuf within Arrow. The language support is > too weak. Language support isn't just about having a binding for different > languages, it is about having a high-quality binding. Could you please expand on

Re: language independent representation of filter expressions

2020-07-11 Thread Jacques Nadeau
For reference, the doc (from eight years ago) I meant to link in my initial message was: https://docs.google.com/document/d/1QTL8warUYS2KjldQrGUse7zp8eA72VKtLOHwfXy6c7I/edit On Sat, Jul 11, 2020, 11:24 AM Wes McKinney wrote: > On Sat, Jul 11, 2020 at 11:55 AM Jacques Nadeau > wrote: > > > > On

Re: language independent representation of filter expressions

2020-07-11 Thread Wes McKinney
On Sat, Jul 11, 2020 at 11:55 AM Jacques Nadeau wrote: > > On Mon, Jul 6, 2020 at 2:45 PM Wes McKinney wrote: > > > I would also be interested in having a reusable serialized format for > > filter- and projection-like expressions. I think trying to go so far > > as full logical query plans suitab

Re: language independent representation of filter expressions

2020-07-11 Thread Jacques Nadeau
On Mon, Jul 6, 2020 at 2:45 PM Wes McKinney wrote: > I would also be interested in having a reusable serialized format for > filter- and projection-like expressions. I think trying to go so far > as full logical query plans suitable for building a SQL engine is > perhaps a bit too far but we coul

Re: language independent representation of filter expressions

2020-07-10 Thread Patrick Pai
Thanks for clarifying! And yes, my bad on the typo. I meant to say format/Schema.fbs On 2020/07/10 04:27:50, Micah Kornfield wrote: > Hi Patrick, > > > I'm working with Steve on this issue. Can you please share what you have > > in mind for something more general than Gandiva's serialized expr

Re: language independent representation of filter expressions

2020-07-09 Thread Micah Kornfield
Hi Patrick, > I'm working with Steve on this issue. Can you please share what you have > in mind for something more general than Gandiva's serialized expressions? Not necessarily something "more" general, but we should ensure that the approach taken should be capable of representing the same info

Re: language independent representation of filter expressions

2020-07-09 Thread Wes McKinney
hey Patrick, I'd like to help provide some input on this -- both design and implementation -- (and others would, too, I am sure) but we are very loaded down right now working on the 1.0.0 release so it may be a week or two before some of us will be able to dedicate some brain cycles to this. Than

Re: language independent representation of filter expressions

2020-07-09 Thread Patrick Pai
I'm working with Steve on this issue. Can you please share what you have in mind for something more general than Gandiva's serialized expressions? I'm currently working through a design. I imagine we will have a FlatBuffer schema defining all expression types and have the different cpp expressio

Re: language independent representation of filter expressions

2020-07-06 Thread Wes McKinney
I would also be interested in having a reusable serialized format for filter- and projection-like expressions. I think trying to go so far as full logical query plans suitable for building a SQL engine is perhaps a bit too far but we could start small with the use case from the JNI Datasets PR as a

Re: language independent representation of filter expressions

2020-07-06 Thread Andy Grove
This is something that I am also interested in. My current approach in my personal project that uses Arrow is to use protobuf to represent expressions (as well as logical and physical query plans). I used the Gandiva protobuf definition as a starting point. Protobuf works for going between differ