Re: WireFormat of Flight SchemaResult and Flight FlightInfo's Schema

2021-07-26 Thread David Li
Sure, I've added you to the JIRA contributors role (so you can self-assign in the future) and assigned the JIRA to you. Thanks for taking this on. -David On Mon, Jul 26, 2021, at 11:06, Nate Bauernfeind wrote: > David, do you mind assigning to me? I'll get a PR up within the next two > days. The

Re: WireFormat of Flight SchemaResult and Flight FlightInfo's Schema

2021-07-26 Thread Nate Bauernfeind
David, do you mind assigning to me? I'll get a PR up within the next two days. The JIRA username is 'nbauernfeind'. On Mon, Jul 26, 2021 at 8:41 AM David Li wrote: > I filed ARROW-13449 for this, thanks for the clarification. > > -David > > On Mon, Jul 26, 2021, at 10:25, Wes McKinney wrote: > >

Re: WireFormat of Flight SchemaResult and Flight FlightInfo's Schema

2021-07-26 Thread David Li
I filed ARROW-13449 for this, thanks for the clarification. -David On Mon, Jul 26, 2021, at 10:25, Wes McKinney wrote: > IIRC, we did intend to encapsulate the Schema in an IPC message. > Updating the docs / comments in the Flight.proto is the right thing to > do. > > On Sun, Jul 25, 2021 at 12:

Re: WireFormat of Flight SchemaResult and Flight FlightInfo's Schema

2021-07-26 Thread Wes McKinney
IIRC, we did intend to encapsulate the Schema in an IPC message. Updating the docs / comments in the Flight.proto is the right thing to do. On Sun, Jul 25, 2021 at 12:47 PM Micah Kornfield wrote: > > I think if all reference implementations are doing this the same way we > should update the docs

Re: WireFormat of Flight SchemaResult and Flight FlightInfo's Schema

2021-07-25 Thread Micah Kornfield
I think if all reference implementations are doing this the same way we should update the docs and I don't think a vote is necessary. On Sun, Jul 25, 2021 at 10:27 AM David Li wrote: > Hey Nate, > > Good catch. I would say it was intentional to use an IPC message (while > the length is redundant

Re: WireFormat of Flight SchemaResult and Flight FlightInfo's Schema

2021-07-25 Thread David Li
Hey Nate, Good catch. I would say it was intentional to use an IPC message (while the length is redundant, it also contains the metadata version and custom metadata), and the comment is a little vague. I'm not sure if we need a vote to update this since it is changing files in the format dir.