Re: Norms for adopting PRs

2023-01-25 Thread Weston Pace
> What is the process if OP has not set "allow contributions to this PR" on GitHub or if the adopted is not an Arrow committer? Does someone fork their fork? You cannot fork a fork. However, you can add a new remote to your fork. This should work: git remote add westonpace https://github.com/we

Re: Norms for adopting PRs

2023-01-25 Thread Neal Richardson
Correct, it does. So as long as you base your branch off of the original contributor's PR, or cherry-pick their commit(s) into yours, the attribution should show up. Neal On Wed, Jan 25, 2023 at 10:54 AM Antoine Pitrou wrote: > > Le 25/01/2023 à 16:47, Julian Hyde a écrit : > > A common practic

Re: Norms for adopting PRs

2023-01-25 Thread Antoine Pitrou
Le 25/01/2023 à 16:47, Julian Hyde a écrit : A common practice in many Git-based projects is to add “Co-authored-by” comments. To Git they are merely lines in the commit message, but they are recognized by GitHub tooling. Our merge script already does that with all commit authors in the PR,

Re: Norms for adopting PRs

2023-01-25 Thread Antoine Pitrou
Hi Anja, Le 24/01/2023 à 23:19, Anja a écrit : A new contributor might not look at this section of the documentation, because it is written for reviewers, not PR authors. That is true. Perhaps it would be desirable to split that document in two: one with general guidelines for what makes a