Re: How to properly serialize subclasses of supported classes

2018-03-05 Thread Robert Nishihara
We just chatted offline. Should be fixed by https://github.com/apache/arrow/pull/1704. On Mon, Mar 5, 2018 at 3:42 AM Mitar wrote: > Hi! > > You mean, this explains why a subclass of list is not being matched? Maybe. > > But I do not get why my custom serialization for ndarray subclass is > neve

Re: How to properly serialize subclasses of supported classes

2018-03-05 Thread Mitar
Hi! You mean, this explains why a subclass of list is not being matched? Maybe. But I do not get why my custom serialization for ndarray subclass is never called. Or how hard would it be to automatically serialize/deserialize into subclasses so that I would not have to have a custom serializatio

Re: How to properly serialize subclasses of supported classes

2018-03-04 Thread Robert Nishihara
The issue is probably this line https://github.com/apache/arrow/blob/8b1c8118b017a941f0102709d72df7e5a9783aa4/cpp/src/arrow/python/python_to_arrow.cc#L504 which uses *PyList_Check* instead of *PyList_CheckExact*. Changing it to the exact form will cause it to use the custom serializer for subclas