Re: Re: Help needed with PR #13659: Fixing build/unit test issues in msvc/win32

2022-08-02 Thread James Duong
On Tue, Jul 26, 2022 at 6:06 AM Arkadiy Vertleyb (BLOOMBERG/ 120 PARK) < avertl...@bloomberg.net> wrote: > From: Arkadiy Vertleyb (BLOOMBERG/ 120 PARK) At: 07/26/22 08:53:54 > UTC-4:00To: wesmck...@gmail.com > Subject: Re: Help needed with PR #13659: Fixing build/unit test issues i

Re: Help needed with PR #13659: Fixing build/unit test issues in msvc/win32

2022-07-25 Thread David Li
022 at 1:23 PM Arkadiy Vertleyb (BLOOMBERG/ 120 PARK) >> > wrote: >> >> >> >> Or live with the warnings. Or cast his sizes to _int64, if the >> warnings are critical. >> >> >> >> From: dev@arrow.apache.org At: 07/22/22 14:06:34 UTC-4

Re: Help needed with PR #13659: Fixing build/unit test issues in msvc/win32

2022-07-25 Thread James Duong
tical. > >> > >> From: dev@arrow.apache.org At: 07/22/22 14:06:34 UTC-4:00To: Arkadiy > Vertleyb (BLOOMBERG/ 120 PARK ) , dev@arrow.apache.org > >> Subject: Re: Help needed with PR #13659: Fixing build/unit test issues > in msvc/win32 > >> > >> The pr

Re: Help needed with PR #13659: Fixing build/unit test issues in msvc/win32

2022-07-25 Thread David Li
t his sizes to _int64, if the warnings are >> critical. >> >> From: dev@arrow.apache.org At: 07/22/22 14:06:34 UTC-4:00To: Arkadiy >> Vertleyb (BLOOMBERG/ 120 PARK ) , dev@arrow.apache.org >> Subject: Re: Help needed with PR #13659: Fixing build/unit test issues in >&

Re: Help needed with PR #13659: Fixing build/unit test issues in msvc/win32

2022-07-25 Thread Wes McKinney
s. Or cast his sizes to _int64, if the warnings are > critical. > > From: dev@arrow.apache.org At: 07/22/22 14:06:34 UTC-4:00To: Arkadiy > Vertleyb (BLOOMBERG/ 120 PARK ) , dev@arrow.apache.org > Subject: Re: Help needed with PR #13659: Fixing build/unit test issues in > ms

Re: Help needed with PR #13659: Fixing build/unit test issues in msvc/win32

2022-07-22 Thread Arkadiy Vertleyb (BLOOMBERG/ 120 PARK)
gt; > From: dev@arrow.apache.org At: 07/22/22 10:18:09 UTC-4:00To: > dev@arrow.apache.org > Subject: Re: Help needed with PR #13659: Fixing build/unit test issues in > msvc/win32 > > > Ah, that's a good point. Then we should probably use explicit casts. > > > Le

Re: Help needed with PR #13659: Fixing build/unit test issues in msvc/win32

2022-07-22 Thread James Duong
> From: dev@arrow.apache.org At: 07/22/22 10:18:09 UTC-4:00To: > dev@arrow.apache.org > Subject: Re: Help needed with PR #13659: Fixing build/unit test issues in > msvc/win32 > > > Ah, that's a good point. Then we should probably use explicit casts. > > > Le 22/07

Re: Help needed with PR #13659: Fixing build/unit test issues in msvc/win32

2022-07-22 Thread Arkadiy Vertleyb (BLOOMBERG/ 120 PARK)
UTC-4:00To: dev@arrow.apache.org Subject: Re: Help needed with PR #13659: Fixing build/unit test issues in msvc/win32 Ah, that's a good point. Then we should probably use explicit casts. Le 22/07/2022 à 15:58, James Duong a écrit : > Seems reasonable to suppress this warning on thi

Re: Help needed with PR #13659: Fixing build/unit test issues in msvc/win32

2022-07-22 Thread Antoine Pitrou
Please let me know how you think we should proceed with this. Thanks, Arkadiy From: dev@arrow.apache.org At: 07/21/22 18:29:33 UTC-4:00To: Arkadiy Vertleyb (BLOOMBERG/ 120 PARK ) , dev@arrow.apache.org Subject: Re: Help needed with PR #13659: Fixing build/unit test issues in msvc/win32 Feed

Re: Help needed with PR #13659: Fixing build/unit test issues in msvc/win32

2022-07-22 Thread James Duong
all changes. > > > > Please let me know how you think we should proceed with this. > > > > Thanks, > > Arkadiy > > > > From: dev@arrow.apache.org At: 07/21/22 18:29:33 UTC-4:00To: Arkadiy > Vertleyb (BLOOMBERG/ 120 PARK ) , dev@arrow.apache.org > >

Re: Help needed with PR #13659: Fixing build/unit test issues in msvc/win32

2022-07-22 Thread Antoine Pitrou
UTC-4:00To: Arkadiy Vertleyb (BLOOMBERG/ 120 PARK ) , dev@arrow.apache.org Subject: Re: Help needed with PR #13659: Fixing build/unit test issues in msvc/win32 Feedback I got here was to use static_cast: https://github.com/apache/arrow/pull/13532#issuecomment-1177488433 I'm indifferent as

Re: Help needed with PR #13659: Fixing build/unit test issues in msvc/win32

2022-07-22 Thread Arkadiy Vertleyb (BLOOMBERG/ 120 PARK)
with this. Thanks, Arkadiy From: dev@arrow.apache.org At: 07/21/22 18:29:33 UTC-4:00To: Arkadiy Vertleyb (BLOOMBERG/ 120 PARK ) , dev@arrow.apache.org Subject: Re: Help needed with PR #13659: Fixing build/unit test issues in msvc/win32 Feedback I got here was to use static_cast:

Re: Help needed with PR #13659: Fixing build/unit test issues in msvc/win32

2022-07-21 Thread James Duong
rkadiy > > > From: dev@arrow.apache.org At: 07/21/22 13:59:51 UTC-4:00To: > dev@arrow.apache.org > Cc: Arkadiy Vertleyb (BLOOMBERG/ 120 PARK ) > Subject: Re: Help needed with PR #13659: Fixing build/unit test issues in > msvc/win32 > > Hi Arkadiy, > > I've been working on

Re: Help needed with PR #13659: Fixing build/unit test issues in msvc/win32

2022-07-21 Thread Arkadiy Vertleyb (BLOOMBERG/ 120 PARK)
:00To: dev@arrow.apache.org Cc: Arkadiy Vertleyb (BLOOMBERG/ 120 PARK ) Subject: Re: Help needed with PR #13659: Fixing build/unit test issues in msvc/win32 Hi Arkadiy, I've been working on a PR for fixing 32-bit Visual Studio here which has some of the same changes. It also enables the

Re: Help needed with PR #13659: Fixing build/unit test issues in msvc/win32

2022-07-21 Thread James Duong
Arkadiy > > Vertleyb (BLOOMBERG/ 120 PARK ) , dev@arrow.apache.org > > Subject: Re: Help needed with PR #13659: Fixing build/unit test issues in > > msvc/win32 > > > > Hi Arkadiy, > > > > For issues 2 and 3 there is currently an issue [1] with the protobuf >

Re: Help needed with PR #13659: Fixing build/unit test issues in msvc/win32

2022-07-21 Thread Raul Cumplido Dominguez
d? > > > From: dev@arrow.apache.org At: 07/21/22 09:51:09 UTC-4:00To: Arkadiy > Vertleyb (BLOOMBERG/ 120 PARK ) , dev@arrow.apache.org > Subject: Re: Help needed with PR #13659: Fixing build/unit test issues in > msvc/win32 > > Hi Arkadiy, > > For issues 2 and 3 there is cu

Re: Help needed with PR #13659: Fixing build/unit test issues in msvc/win32

2022-07-21 Thread Arkadiy Vertleyb (BLOOMBERG/ 120 PARK)
Thanks Raul. Does this mean issues 1-3 are not really caused by my PR and I just need to wait for them to be fixed? From: dev@arrow.apache.org At: 07/21/22 09:51:09 UTC-4:00To: Arkadiy Vertleyb (BLOOMBERG/ 120 PARK ) , dev@arrow.apache.org Subject: Re: Help needed with PR #13659: Fixing

Re: Help needed with PR #13659: Fixing build/unit test issues in msvc/win32

2022-07-21 Thread Sten Larsson
Regarding 1: Looks like Homebrew recently moved glib-mkenums into a separate package called glib-utils. /Sten

Re: Help needed with PR #13659: Fixing build/unit test issues in msvc/win32

2022-07-21 Thread Raul Cumplido Dominguez
Hi Arkadiy, For issues 2 and 3 there is currently an issue [1] with the protobuf version [2] distributed with homebrew [3] happening on master. These ones should be fixed once the upstream homebrew package is distributed. Issue 1 is also happening on master and I am not sure whether the issue is t