Cool -- thanks Jorge and Andy. I'll start working on an actual proposed PR
to merge. I really like Jorge's idea of trying to port the Aggregate
operator to use a LogicalPlan Node style and see how easy that would be.
Andrew
On Sat, Aug 22, 2020 at 12:01 PM Andy Grove wrote:
> I've added some co
I've added some comments as well. I fully support converting LogicalPlan
from enum to trait. You will notice that I implemented PhysicalPlan using
traits, because I had more Rust experience at the time I did this work.
There are going to be some design challenges to make this change, I'm sure,
but
Hi Andrew,
I carefully went through the document and the PR. Thank you for this!
I believe that the improvements on the PR alone are a major benefit, as it
supports custom logical plans out of the box, which opens a lot of
possibilities to users.
I also like the idea of migrating from enum to a
