Re: [Discuss] [Java] Implement vector diff functionality

2020-03-12 Thread Micah Kornfield
It probably pays to have at least two issues one for porting the diff, and the existing one I made. On Wed, Mar 11, 2020 at 1:45 AM Ji Liu wrote: > Hi Micah, > Thanks for your feedback, you have opened an issue for Google's Truth[1] > and it was assigned to me, I'll try to use it. > > Thanks, >

Re: [Discuss] [Java] Implement vector diff functionality

2020-03-11 Thread Ji Liu
Hi Micah, Thanks for your feedback, you have opened an issue for Google's Truth[1] and it was assigned to me, I'll try to use it. Thanks, Ji Liu [1] https://issues.apache.org/jira/browse/ARROW-6931 -- From:Micah Kornfield Send Ti

Re: [Discuss] [Java] Implement vector diff functionality

2020-03-10 Thread Micah Kornfield
I'm in favor of this. I think this can be combined with a custom matcher for Google's Truth [1] library, to make a lot of our unit tests much more readable [1] https://github.com/google/truth On Thu, Mar 5, 2020 at 11:29 PM Ji Liu wrote: > > Hi all, > In C++ side, we already have array diff fu