Hi,
Thank you all.
I didn't report this thread to the INFRA issue (because this
discussion isn't finished yet) but INFRA found this and
changed the default commit message for merge button to
"Default to pull request title and description".
(The default value was changed but we can continue to
di
+1 for title and description
For purely personal reason. I care about commit messages and often try
writing informative messages (even following pedantic rules like 72
chars length). It's a bit disappointed if the messages are not shown by
`git log`.
On 2/1/23 10:46, Jacob Wujciak wrote:
Y
Yes same here I personally don't use the git log much but I am fine with
title + description if it is beneficial for others
Joris Van den Bossche schrieb am Di., 31.
Jan. 2023, 22:28:
> And to be explicit, as mentioned in my original post, I am fine with
> both, so +1 on title + description
>
>
And to be explicit, as mentioned in my original post, I am fine with
both, so +1 on title + description
On Tue, 31 Jan 2023 at 21:53, Matthew Topol
wrote:
>
> (non-binding) I am also +1 for title + description
>
> On Tue, Jan 31, 2023 at 11:17 AM Neal Richardson <
> neal.p.richard...@gmail.c
(non-binding) I am also +1 for title + description
On Tue, Jan 31, 2023 at 11:17 AM Neal Richardson <
neal.p.richard...@gmail.com> wrote:
> +1, with or without description
>
> Neal
>
> On Tue, Jan 31, 2023 at 11:04 AM Weston Pace
> wrote:
>
> > +1 to both. This only applies to the merge bu
+1, with or without description
Neal
On Tue, Jan 31, 2023 at 11:04 AM Weston Pace wrote:
> +1 to both. This only applies to the merge button and, in that case, the
> committer has a chance to review the message before merging. So if there
> is garbage in the description hopefully they can cat
+1 to both. This only applies to the merge button and, in that case, the
committer has a chance to review the message before merging. So if there
is garbage in the description hopefully they can catch this here and adjust
it or ask for a cleanup of the description.
Also, it seems we're trying to
I am also +1 for title + description.
On Tue, Jan 31, 2023, at 05:16, Felipe Oliveira Carvalho wrote:
> +1 for "pull request title *and* description".
>
> Being able to read descriptions without leaving the editor is handy.
> Keeping that information tracked in the repo means we don’t depend on
>
+1 for "pull request title *and* description".
Being able to read descriptions without leaving the editor is handy.
Keeping that information tracked in the repo means we don’t depend on
GitHub to reconstruct the history of the project.
On Tue, 31 Jan 2023 at 06:43 Antoine Pitrou wrote:
>
> +1 f
+1 for "pull request title *and* description".
I'd rather have the description recorded in git than have to look up a
PR to get more explanations. Also, we don't know what Github will have
become in 10 years.
Le 31/01/2023 à 09:53, Joris Van den Bossche a écrit :
I would personally prefe
+1 on only title
Joris Van den Bossche schrieb am Di., 31.
Jan. 2023, 09:54:
> I would personally prefer to use just "Pull request title" instead of
> "Pull request title and description".
>
> In my experience, including the description in the commit message (as
> we already do) more often gives
I would personally prefer to use just "Pull request title" instead of
"Pull request title and description".
In my experience, including the description in the commit message (as
we already do) more often gives noise to the output of `git log`, and
you can always go from the commit to the PR to see
+1
We already do it on the merge script and we have already changed it on the
`arrow-site` repo.
El mar, 31 ene 2023 a las 9:13, Sutou Kouhei ()
escribió:
> Hi,
>
> We need to get consensus to change the default commit
> message for merge button:
>
> https://issues.apache.org/jira/browse/INFRA-24
13 matches
Mail list logo
