Re: [DISCUSS] Arrow Java: add RelWithDebInfo builds support

2025-03-12 Thread David Li
That makes sense to me. 500MB is a bit excessive (well, 94MB also sounds excessive but I suppose that's LLVM). Maybe we can host the separated debug symbols as part of the GitHub release instead? re: runner space, something like this should work [1]. [1]: https://github.com/apache/arrow-adbc/

Re: [DISCUSS] Arrow Java: add RelWithDebInfo builds support

2025-03-12 Thread Jean-Baptiste Onofré
Hi Yes, agree with Kou and Jacob: we should probably strip and "square" to only keep debug. Thoughts ? Regards JB On Wed, Mar 12, 2025 at 12:41 PM Jacob Wujciak wrote: > > Thanks for testing this Logan! We probably have to clear some more > disk space on the runner, this is a problem we have h

Re: [DISCUSS] Arrow Java: add RelWithDebInfo builds support

2025-03-12 Thread Jacob Wujciak
Thanks for testing this Logan! We probably have to clear some more disk space on the runner, this is a problem we have had before, they keep adding things to the image. A 5x increase seems a bit much to integrate into the normal builds, so Kou's approach is probably best? Am Mi., 12. März 2025 um

Re: [DISCUSS] Arrow Java: add RelWithDebInfo builds support

2025-03-11 Thread Logan Riggs
I did a quick test building with RelWithDebInfo. Unfortunately the arrow-java github runners ran out of space for the unix builds. Instead I built locally and for Arm64 Linux the gandiva .so file is 573mb vs 94mb for a release build. On Tue, Mar 11, 2025 at 6:19 PM Sutou Kouhei wrote: > Hi, > >

Re: [DISCUSS] Arrow Java: add RelWithDebInfo builds support

2025-03-11 Thread Sutou Kouhei
Hi, It seems that deb (dh_strip) uses objcopy for this. See also the "--only-keep-debug" option section in objcopy(1): https://man7.org/linux/man-pages/man1/objcopy.1.html > --only-keep-debug > Strip a file, removing contents of any sections that would not > be stripped by --strip-debug

Re: [DISCUSS] Arrow Java: add RelWithDebInfo builds support

2025-03-11 Thread Jacob Wujciak
Hi JB, Sounds useful to me. As the JNI libarrow binaries are build in arrow-java I don't see an issue with adding this. Given that RelWithDebInfo has the same optimizations etc. as Release the main deciding factor to drop deb info is binary size. IIRC the java binaries are our largest artifacts a