Re: [CI] Code coverage reports

2018-05-15 Thread Antoine Pitrou
Hi, There's now a draft PR that generates and uploads Python / Cython code coverage. See example report here: https://codecov.io/gh/apache/arrow/pull/2050/list/ Regards Antoine. On Sat, 12 May 2018 16:18:47 +0200 Antoine Pitrou wrote: > Le 12/05/2018 à 00:55, Wes McKinney a écrit : > > >

Re: [CI] Code coverage reports

2018-05-13 Thread Uwe L. Korn
Hello Antoine, the code coverage reports look good and they are a nice tool to see where we missing coverage. Thank you for fixing them. Uwe On Sat, May 12, 2018, at 4:18 PM, Antoine Pitrou wrote: > > Le 12/05/2018 à 00:55, Wes McKinney a écrit : > > > > Thanks for doing this! I am sure our c

Re: [CI] Code coverage reports

2018-05-12 Thread Antoine Pitrou
Le 12/05/2018 à 00:55, Wes McKinney a écrit : > > Thanks for doing this! I am sure our code coverage has suffered as a > result of not having the reports. I wonder what it would take to get > C++ coverage that includes lines touched by Python unit test execution Nothing, because it already does

Re: [CI] Code coverage reports

2018-05-11 Thread Wes McKinney
hey Antoine, Looks like codecov is enabled now. I'm not sure when that happened, maybe when we made the Gitbox transition? The last time I took up this issue with ASF Infra was in 2016, I can't seem to find the ticket, but here is one where they say the "permissions are too broad" https://issues.

Re: [CI] Code coverage reports

2018-05-11 Thread Antoine Pitrou
Hi Wes, Le 11/05/2018 à 05:32, Wes McKinney a écrit : > > I also prefer codecov.io, but unfortunately Apache Infra does not > support it I believe due to some app hook permissions issue (there are > some similar problems preventing CircleCI from being made available to > Apache projects). I have

Re: [CI] Code coverage reports

2018-05-10 Thread Wes McKinney
hi Antoine, I also prefer codecov.io, but unfortunately Apache Infra does not support it I believe due to some app hook permissions issue (there are some similar problems preventing CircleCI from being made available to Apache projects). I have asked before, you are welcome to open an INFRA ticket