Re: [Acero] Error handling in ExecNode

2022-10-18 Thread Weston Pace
Yes. Something like: if (ErrorIfNotOk(flight_writer->WriteRecordBatch(...))) return; Today this method calls `output->ErrorReceived(...)`. The original idea (I think) is that, possibly, a downstream node could "handle" the error. However, in practice, nothing does that, and all errors propagat

Re: [Acero] Error handling in ExecNode

2022-10-18 Thread Yaron Gvili
Hi Li, One way I've seen (which hopefully is the right way) is invoking `ExecNode::ErrorIfNotOk(Status)`. If `WriteRecordBatch` returns a `Status` then just pass it; if it returns a `Result` then you can pass its `.status()`. Yaron. From: Li Jin Sent: Tuesday,