Re: cpp Memory Pool Clarification

2022-07-12 Thread Weston Pace
er and > MakeReaderGenerator) to generate for a regular source node. > > -Original Message- > From: Weston Pace > Sent: Monday, July 11, 2022 4:37 PM > To: dev@arrow.apache.org > Subject: Re: cpp Memory Pool Clarification > > > Is there anything else I

RE: cpp Memory Pool Clarification

2022-07-12 Thread Ivan Chau
generate for a regular source node. -Original Message- From: Weston Pace Sent: Monday, July 11, 2022 4:37 PM To: dev@arrow.apache.org Subject: Re: cpp Memory Pool Clarification > Is there anything else I'd need to change? Maybe try something like this: https://github.com/westonpa

Re: cpp Memory Pool Clarification

2022-07-12 Thread Li Jin
); > > > > ExecContext ctx(&logging_pool, ...); > > > > ``` > > > > > > > > Is there anything else I'd need to change? > > > > > > > > Beyond that, we should also expect to see some allocations from > > > TableSourc

Re: cpp Memory Pool Clarification

2022-07-11 Thread Weston Pace
pool()); > > > ExecContext ctx(&logging_pool, ...); > > > ``` > > > > > > Is there anything else I'd need to change? > > > > > > Beyond that, we should also expect to see some allocations from > > TableSourceNode going through the logg

Re: cpp Memory Pool Clarification

2022-07-11 Thread Li Jin
g through the logging memory pool, even if AsOfJoinNode > was using the default memory pool instead of the Exec Plan's pool, but I am > not seeing anything come through... > > > > -Original Message- > > From: Weston Pace > > Sent: Monday, July 1

Re: cpp Memory Pool Clarification

2022-07-11 Thread Weston Pace
also expect to see some allocations from > TableSourceNode going through the logging memory pool, even if AsOfJoinNode > was using the default memory pool instead of the Exec Plan's pool, but I am > not seeing anything come through... > > -Original Message- >

RE: cpp Memory Pool Clarification

2022-07-11 Thread Ivan Chau
g come through... -Original Message- From: Weston Pace Sent: Monday, July 11, 2022 2:47 PM To: dev@arrow.apache.org Subject: Re: cpp Memory Pool Clarification Are you changing the default memory pool to a LoggingMemoryPool? Where are you doing this? For a benchmark I think you would need to change the

Re: cpp Memory Pool Clarification

2022-07-11 Thread Weston Pace
Are you changing the default memory pool to a LoggingMemoryPool? Where are you doing this? For a benchmark I think you would need to change the implementation in the benchmark file itself. Similarly, is AsofJoinNode using the default memory pool or the memory pool of the exec plan? It should be