Re: Question about thread local data in `QueryContext`

2023-03-09 Thread Ruoxi Sun
Got it, that makes sense. Thanks for the answer, really appreciate it! *Rossi Sun* Sasha Krassovsky 于2023年3月10日周五 14:38写道: > Hi Rossi, > It is supposed to be used by every node that needs a temporary array. It > is not used because we haven’t performed the refactor. > > Sasha > > > 9 марта 20

Re: Question about thread local data in `QueryContext`

2023-03-09 Thread Sasha Krassovsky
Hi Rossi, It is supposed to be used by every node that needs a temporary array. It is not used because we haven’t performed the refactor. Sasha > 9 марта 2023 г., в 21:57, Ruoxi Sun написал(а): > > Hi Sasha, thanks for the kind reply. Yeah, that makes sense for using > thread local data to r

Re: Question about thread local data in `QueryContext`

2023-03-09 Thread Ruoxi Sun
Hi Sasha, thanks for the kind reply. Yeah, that makes sense for using thread local data to reduce the vector allocation/deallocation overhead. However I'm still wondering if this thread local data has to be in QueryContext? Specifically, there is thread local state

Re: Question about thread local data in `QueryContext`

2023-03-09 Thread Sasha Krassovsky
Hi Rossi, When profiling Acero we noticed that there was a lot of overhead regarding memory allocation, specifically in the creation/destruction of std::vector. This thread local data in QueryContext was put there as a preparation to refactor other nodes to use TempVectorStack when they need a t

Question about thread local data in `QueryContext`

2023-03-09 Thread Ruoxi Sun
Hi folks, I see that the member `tld_ ` in class `QueryContext` is used by `BloomFilterPushdownContext