Re: Proposed Java ArrowStreamReader/MessageReader API Changes

2018-07-16 Thread Bryan Cutler
Thanks for the comments Li. For your concerns about memory ownership, I don't think anything is really changed here, but we can discuss further in the PR. I'm not sure I quite understand your concern when you say "complexity of maintaining both style APIs"? The proposed changes are for 1 coheren

Re: Proposed Java ArrowStreamReader/MessageReader API Changes

2018-07-15 Thread Li Jin
Bryan, Sorry for the delay. I did a round of review of the API change (high level). I understand the proposed API changes allows users of the Arrow Java library to implement Arrow reader that reads Arrow data to on-heap memory directly. However, my main feedback is that the proposed API changes i

Re: Proposed Java ArrowStreamReader/MessageReader API Changes

2018-07-09 Thread Li Jin
Bryan, Sorry I am traveling now but I will try to take to look in the next few days. Li On Mon, Jul 9, 2018 at 11:16 PM, Bryan Cutler wrote: > Hi All, > > I'm proposing some Java API changes to MessageReader, with minor changes to > ArrowStreamReader and MessageSerializer, as part of ARROW-270

Proposed Java ArrowStreamReader/MessageReader API Changes

2018-07-09 Thread Bryan Cutler
Hi All, I'm proposing some Java API changes to MessageReader, with minor changes to ArrowStreamReader and MessageSerializer, as part of ARROW-2704 [1] and can be seen in the PR [2]. These changes are to improve processing an Arrow stream on a per Message basis. A while ago I introduced the Messag