Re: Getting some more eyes on the R bindings work

2018-09-21 Thread Romain François
Some of those lines are generated automatically by roxygen, and some of them are the license headers ;-) Still the pr is substantial, esp compared to the previous one. Let me know if I can help the process, e.g. write some notes about how R6 is used, the very low level bindings is quite mecha

Getting some more eyes on the R bindings work

2018-09-21 Thread Wes McKinney
Romain just submitted a ~4500 line R patch https://github.com/apache/arrow/pull/2596 I am going to do my best to give feedback, particularly at the C++ binding level, but it would be great to get some more eyes on the R-level API. As one detail, R6 classes are being used to create the wrapper int