Re: Flight authentication interoperability

2019-07-08 Thread David Li
I've filed/found the following: ARROW-4575 [1] for adding Python to the Flight integration tests ARROW-5875 [2] for adding RPC features (like auth) to integration tests ARROW-1009 [3] for async APIs ARROW-5876 [4] for implementing basic auth across all languages ARROW-5877 [5] for documenting the

Re: Flight authentication interoperability

2019-07-06 Thread Wes McKinney
Are there some action items (JIRA issues) to follow up here? At minimum having documentation about this for the Python client side would seem to be in order. On Thu, Jul 4, 2019 at 2:20 PM Ryan Murray wrote: > > Hey David, > > I was actually testing test_flight.test_http_basic_auth(). But I think

Re: Flight authentication interoperability

2019-07-04 Thread Ryan Murray
Hey David, I was actually testing test_flight.test_http_basic_auth(). But I think the same applies. The Java default implementation expects a handshake. More to the point it expects a BasicAuth protobuf which I believe is not exposed at all in python. Always returning true in BasicServerAuthHandle

Re: Flight authentication interoperability

2019-07-04 Thread David Li
Hmm, interesting. I assume you mean test_flight.test_token_auth() as the client? The tests weren't written to be explicitly compatible, but there's no reason you should get an indefinite stall. We don't use Handshake/ServerAuthHandler#authenticate, so that would explain why we don't see issues. I

Re: Flight authentication interoperability

2019-07-04 Thread Ryan Murray
Hey David, I am curious to see what you are doing different from me. I am running the Java ExampleFlightServer.java against the python auth flight tests and they are not passing. The particular issue is that incoming.next() never returns in BasicServerAuthHandler.java:56 It doesn't appear to be a

Re: Flight authentication interoperability

2019-07-04 Thread Antoine Pitrou
It may be worth opening a JIRA for the flaky tests if not already done. Regards Antoine. Le 04/07/2019 à 18:11, David Li a écrit : > I'm also curious as to what the issue was, as we've been doing > Python-client-Java-server auth with development builds without > trouble. > > Regardless - thi

Re: Flight authentication interoperability

2019-07-04 Thread David Li
I'm also curious as to what the issue was, as we've been doing Python-client-Java-server auth with development builds without trouble. Regardless - this does point out a need for more cross-language Flight testing (perhaps a Flight-specific integration suite?), and to get existing tests running mo

Re: Flight authentication interoperability

2019-07-04 Thread Jacques Nadeau
Which is exactly why I was withholding a vote until there was more information. On Thu, Jul 4, 2019, 7:25 AM Antoine Pitrou wrote: > On Thu, 4 Jul 2019 09:04:34 -0500 > Wes McKinney wrote: > > > > That being said, with Ryan's issue, he is using a feature > > (cross-language auth in Flight) that

Re: Flight authentication interoperability

2019-07-04 Thread Antoine Pitrou
On Thu, 4 Jul 2019 09:04:34 -0500 Wes McKinney wrote: > > That being said, with Ryan's issue, he is using a feature > (cross-language auth in Flight) that isn't being tested. The Flight > integration tests do not use authentication AFAIK so I'm not surprised > to hear that there may be an issue w