Turns out I have:
romain@purrplex ~/git/apache/arrow/r $ clang-format --version
clang-format version 8.0.0 (tags/google/stable/2018-08-24)
So I just made a symlink in my ~/bin/
Travis is happy about it. PR sent.
Romain
> Le 27 sept. 2018 à 22:43, Wes McKinney a écrit :
>
> I found it weird
I found it weird that Homebrew uses non-standard version numbers for
clang-format. I would think the versions would align with the Homebrew LLVM
versions
On Thu, Sep 27, 2018, 10:40 PM Romain François wrote:
> Thanks. I had clang-format already (through brew). I’ll check in the
> morning about v
Thanks. I had clang-format already (through brew). I’ll check in the morning
about version 6.
It is a bit unfortunate that I can build arrow with what i have but need other
versions for linting.
Sorry about the emojis.
Romain
> Le 27 sept. 2018 à 22:10, Wes McKinney a écrit :
>
> Well, y
Well, you have to install LLVM 6 =)
if you're on macOS (just guessing, since I can't read your emojis on
my dilapidated Linux laptop)
http://releases.llvm.org/6.0.0/clang%2bllvm-6.0.0-x86_64-apple-darwin.tar.xz
here's a page I found in installing with this method (unless you want
to build from s
Getting this:
romain@purrplex ~/git/apache/arrow/r $ ./lint.sh --fix
Traceback (most recent call last):
File
"/Users/romain/git/apache/arrow/r/../cpp/build-support/run_clang_format.py",
line 74, in
"-i"] + formatted_filenames)
File "/Users/romain/anaconda3/lib/python3.6/subprocess.py",
Thanks. I will do that on a few hours and then i have a small PR (about support
for logical vectors) ready to go and associated with a jira issue i opened this
morning.
Romain
> Le 27 sept. 2018 à 18:46, Wes McKinney a écrit :
>
> I checked out your branch and ran r/lint.sh and it printed th
I checked out your branch and ran r/lint.sh and it printed the following
https://gist.github.com/wesm/42f1682565ac9737fecc60d12a15927e
You can run
./lint.sh --fix
to fix the problems
On Thu, Sep 27, 2018 at 9:46 AM Romain François wrote:
>
> I don’t think that’s just that. I sent a new build a
I don’t think that’s just that. I sent a new build anyway that is ahead of the
upstream repo.
In any case, there’s probably something i should be doing.
Romain
> Le 27 sept. 2018 à 13:19, Wes McKinney a écrit :
>
> Looks like you need to rebase your branch
>> On Thu, Sep 27, 2018 at 7:18 AM
Looks like you need to rebase your branch
On Thu, Sep 27, 2018 at 7:18 AM Wes McKinney wrote:
>
> hi Romain,
>
> I just put this in the README
> https://github.com/apache/arrow/tree/master/r#development
>
> - Wes
> On Thu, Sep 27, 2018 at 7:17 AM Romain François wrote:
> >
> > Hello,
> >
> > Is
hi Romain,
I just put this in the README
https://github.com/apache/arrow/tree/master/r#development
- Wes
On Thu, Sep 27, 2018 at 7:17 AM Romain François wrote:
>
> Hello,
>
> Is there documentation about what i should be doing to make clang-format
> happy? E.g to make this build pass:
> https:
Hello,
Is there documentation about what i should be doing to make clang-format happy?
E.g to make this build pass:
https://travis-ci.org/romainfrancois/arrow/builds/434027141
Romain
11 matches
Mail list logo
