Re: C++ Migrate from Arrow 0.16.0

2021-06-03 Thread Antoine Pitrou
It should work as long as the union itself doesn't have nulls: https://github.com/apache/arrow/blob/master/cpp/src/arrow/ipc/reader.cc#L351 Regards Antoine. Le 03/06/2021 à 06:42, Micah Kornfield a écrit : I think the one place where it might break is for Union types (I seem to recall a bre

Re: C++ Migrate from Arrow 0.16.0

2021-06-02 Thread Micah Kornfield
I think the one place where it might break is for Union types (I seem to recall a breaking change just prior to 1.0). On Wed, Jun 2, 2021 at 1:00 PM Antoine Pitrou wrote: > > Le 02/06/2021 à 21:57, Rares Vernica a écrit : > > Thanks for the pointers! The migration is going well. > > > > We have

Re: C++ Migrate from Arrow 0.16.0

2021-06-02 Thread Antoine Pitrou
Le 02/06/2021 à 21:57, Rares Vernica a écrit : Thanks for the pointers! The migration is going well. We have been using Arrow 0.16.0 RecordBatchStreamWriter with & without CompressedOutputStream and wrote the resultin

Re: C++ Migrate from Arrow 0.16.0

2021-06-02 Thread Rares Vernica
Thanks for the pointers! The migration is going well. We have been using Arrow 0.16.0 RecordBatchStreamWriter with & without CompressedOutputStream and wrote the resulting Arrow Buffer data to S3

Re: C++ Migrate from Arrow 0.16.0

2021-05-27 Thread Benjamin Kietzman
Yes this is an adaptation of ARROW_ASSIGN_OR_RAISE for their bridge, which seems to throw exceptions instead of returning Status/Result On Thu, May 27, 2021 at 4:42 PM Micah Kornfield wrote: > For the macro, I believe ARROW_ASSIGN_OR_RAISE already does this? > > On Thu, May 27, 2021 at 1:19 PM B

Re: C++ Migrate from Arrow 0.16.0

2021-05-27 Thread Micah Kornfield
For the macro, I believe ARROW_ASSIGN_OR_RAISE already does this? On Thu, May 27, 2021 at 1:19 PM Benjamin Kietzman wrote: > unique_ptr is used to designate unique ownership of the buffer > just created. It's fairly compatible with shared_ptr since > unique_ptr can convert implicitly to shared_p

Re: C++ Migrate from Arrow 0.16.0

2021-05-27 Thread Benjamin Kietzman
unique_ptr is used to designate unique ownership of the buffer just created. It's fairly compatible with shared_ptr since unique_ptr can convert implicitly to shared_ptr. One other refactoring in play here: we've been moving from Status-returning-out-argument functions to the more ergonomic Result

C++ Migrate from Arrow 0.16.0

2021-05-27 Thread Rares Vernica
Hello, We are trying to migrate from Arrow 0.16.0 to a newer version, hopefully up to 4.0.0. The Arrow 0.17.0 change in AllocateBuffer from taking a shared_ptr to returning a unique_ptr is making things very difficult. We wonder if there is a strong reason behind the change from shared_ptr to uniq