Re: [Flight Format] Authentication Redesign

2020-09-05 Thread David Li
Hey James, I think adding a separate capabilities endpoint is a good idea - it doesn't need to be a bidirectional streaming endpoint which would simplify implementation/usage and it would make it easier to maintain backwards compatibility or slowly phase out handshake. Best, David On 9/4/20, Jam

Re: [Flight Format] Authentication Redesign

2020-09-04 Thread James Duong
Are we concerned about backward compatibility with older FlightClients? Would it make sense to continue to support handshakes with auth payloads in addition to header-based authentication using middlewares? Perhaps we create a dedicated endpoint for server capabilities if we need to remain backward

Re: [Flight Format] Authentication Redesign

2020-09-03 Thread David Li
The C++/Python authentication implementation is entirely different (because the C++/Python/Java gRPC APIs are in turn entirely different). In particular, gRPC middleware in C++ is still experimental (compared to Java) and much more limited (unless recent versions changed this). C++/Python might fun

Re: [Flight Format] Authentication Redesign

2020-09-02 Thread James Duong
Looking towards the future a bit, I don't see some of the facilities we used for the Java code in the C++ Flight port. Primarily the use of CallOptions -- I don't see existing functionality for wrapping the gRPC stub within the context of a single request. I do see that we pass in FlightCallOptions

Re: [Flight Format] Authentication Redesign

2020-09-01 Thread David Li
Hey James, I won't be able to attend tomorrow, but seeing as I've been commenting so far - the changes as summarized in the presentation (+I think the latest comments in the doc) look good to me, thanks for working through the proposal with us. Best, David On 9/1/20, James Duong wrote: > Hi, >

Re: [Flight Format] Authentication Redesign

2020-09-01 Thread James Duong
Hi, I would like to talk about the changes in the design document and PR in tomorrow's meeting. I've created a slide deck to get the discussion going. https://docs.google.com/presentation/d/1Bcvu0o0SEL21EMazA6O9fVfYZnzyvsQoKKBCN0NIdi0/edit?usp=drivesdk Thanks! On Wed, Aug 26, 2020, 13:12 James

Re: Authentication Redesign

2020-08-26 Thread James Duong
Hi everyone, I've updated the PR and responded to comments in the proposal document. The PR now makes handshake optional and sends auth information with every request. The client now needs to supply a CredentialCallOption containing auth information (as a Consumer), which we'll convert to a gRPC C

Re: Authentication Redesign

2020-08-20 Thread James Duong
Comments should be enabled now. Thanks for the feedback so far.

Re: Authentication Redesign

2020-08-20 Thread Antoine Pitrou
Could you enable comments on this document? Le 20/08/2020 à 18:49, James Duong a écrit : > Thanks Ryan. > I had an issue moving this document between a few other Google Drives. > > This is the correct link: > https://docs.google.com/document/d/1k3hdbGeE89jiMZ2oKpoIZEs7HAQmVs_RWOmU7fTpLjQ/ > >

Re: Authentication Redesign

2020-08-20 Thread James Duong
Thanks Ryan. I had an issue moving this document between a few other Google Drives. This is the correct link: https://docs.google.com/document/d/1k3hdbGeE89jiMZ2oKpoIZEs7HAQmVs_RWOmU7fTpLjQ/ On Thu, Aug 20, 2020 at 12:48 AM Ryan Murray wrote: > Hey James, > > Looks like the doc is not entirel