Re: Arrow C-Data and DuckDB

2022-05-31 Thread Antoine Pitrou
For the record, https://github.com/apache/arrow/pull/13115 was merged with the proposed change. Regards Antoine. On Fri, 13 May 2022 17:48:21 +0200 Antoine Pitrou wrote: > I don't think this needs a vote, there is no functional change in the > spec, it's just an additional technical recomm

Re: Arrow C-Data and DuckDB

2022-05-13 Thread Antoine Pitrou
I don't think this needs a vote, there is no functional change in the spec, it's just an additional technical recommendation that can go through the regular PR process. Regards Antoine. Le 12/05/2022 à 22:24, David Li a écrit : Thanks all for the comments. I see Tom also put up a PR to a

Re: Arrow C-Data and DuckDB

2022-05-12 Thread David Li
Thanks all for the comments. I see Tom also put up a PR to add this to DuckDB [1]. Do we need a vote for this? If so unless there are further comments I think we can start one. [1]: https://github.com/duckdb/duckdb/pull/3628 On Tue, May 10, 2022, at 13:31, David Li wrote: > For discussion I've

Re: Arrow C-Data and DuckDB

2022-05-10 Thread David Li
For discussion I've put up https://github.com/apache/arrow/pull/13115 to add this for the C data/stream interfaces. On Mon, May 9, 2022, at 15:42, Antoine Pitrou wrote: > Le 09/05/2022 à 20:28, Tomek Drabas a écrit : >> I am new to this board so please, let me know if any of this doesn't make >>

Re: Arrow C-Data and DuckDB

2022-05-09 Thread Antoine Pitrou
Le 09/05/2022 à 20:28, Tomek Drabas a écrit : I am new to this board so please, let me know if any of this doesn't make sense. I am building a FligthSQL example with DuckDB backend. DuckDB already has an Arrow interface defined in duckdb.h that returns ArrowArray. However, the import is not gu

Re: Arrow C-Data and DuckDB

2022-05-09 Thread Dewey Dunnington
I would also love to see a canonical way to do this! My personal workaround has been to guard my own include with #ifndef ARROW_FLAG_DICTIONARY_ORDERED (but that's clearly a hack). On Mon, May 9, 2022 at 3:28 PM Tomek Drabas wrote: > I am new to this board so please, let me know if any of this d

Arrow C-Data and DuckDB

2022-05-09 Thread Tomek Drabas
I am new to this board so please, let me know if any of this doesn't make sense. I am building a FligthSQL example with DuckDB backend. DuckDB already has an Arrow interface defined in duckdb.h that returns ArrowArray. However, the import is not guarded in any way, and ArrowArray is redefined in d