Re: [VOTE] Statistics through the C data interface

2024-12-05 Thread Dewey Dunnington
With apologies for not reviewing this earlier, I've reviewed it now! I am +0 in its current state just because of the title (the proposal seems to be about abstract arrays and not necessarily the C data interface except for the title). Happy to keep up with reviews to get this merged soon! Cheers

Re: [VOTE] Statistics through the C data interface

2024-12-05 Thread Antoine Pitrou
I don't think a second implementation is strictly necessary because this is just defining a schema and some conventions around it. Though of course a second implementation is always better to have. Regards Antoine. Le 05/12/2024 à 17:47, Matt Topol a écrit : * I implemented this proposal

Re: [VOTE] Statistics through the C data interface

2024-12-05 Thread Antoine Pitrou
Hi, While I'm generally in favor of accepting this soon, I'm -1 on accepting it right now because it seems the PR hasn't had enough review attention on it (I posted some comments). A spec is an important document that will bind us for years, so let's make sure we write something that will

Re: [VOTE] Statistics through the C data interface

2024-12-05 Thread Matt Topol
> * I implemented this proposal only in C++. The implementation is already merged into apache/arrow. Should we have one more implementation like format specification change? http://crossbow.voltrondata.com/pr_docs/43553/format/Changing.html#at-least-two-reference-implementations Sorry to be

Re: [VOTE] Statistics through the C data interface

2024-12-04 Thread Gang Wu
+1 (binding) I've left a minor comment to solicit concrete examples of data in the statistics array if this is reasonable. Best, Gang On Thu, Dec 5, 2024 at 11:17 AM wish maple wrote: > +1 (non-binding) > > Best, > Xuwei Fu > > Sutou Kouhei 于2024年12月5日周四 10:58写道: > > > Hi, > > > > I would lik

Re: [VOTE] Statistics through the C data interface

2024-12-04 Thread wish maple
+1 (non-binding) Best, Xuwei Fu Sutou Kouhei 于2024年12月5日周四 10:58写道: > Hi, > > I would like to propose standardizing how to pas statistics > through the C data interface. > > Motivation: > > * We want to pass not only Apache Arrow data but also > statistics of them through the C data interface

Re: [VOTE] Statistics through the C data interface

2024-12-04 Thread Sutou Kouhei
+1 (binding) In <20241205.115838.1127368632150173631@clear-code.com> "[VOTE] Statistics through the C data interface" on Thu, 05 Dec 2024 11:58:38 +0900 (JST), Sutou Kouhei wrote: > Hi, > > I would like to propose standardizing how to pas statistics >

[VOTE] Statistics through the C data interface

2024-12-04 Thread Sutou Kouhei
Hi, I would like to propose standardizing how to pas statistics through the C data interface. Motivation: * We want to pass not only Apache Arrow data but also statistics of them through the C data interface for query planning. Approach: * Define a standardized schema for statistics. * Rep