Re: [Rust] crate versions and release process

2019-01-06 Thread Chao Sun
gt; > >merging > > > > >> > into arrow, and I think it's better to maintain the continuity > > > > >there. > > > > >> > > > > > >> > This could be a little bit problematic from an ASF release > point of > >

Re: [Rust] crate versions and release process

2019-01-06 Thread Wes McKinney
> > >(this > > > >> > creates extra work for maintainers)? If not then it is probably > > > >best > > > >> > to use the same version everywhere. > > > >> > > > > >> > - Wes > > > >> > > > > >> >

Re: [Rust] crate versions and release process

2019-01-06 Thread Chao Sun
t; >> > On Sat, Jan 5, 2019 at 1:32 AM Kouhei Sutou > > >wrote: > > >> > > > > >> > > Hi, > > >> > > > > >> > > I have no opinion about version of sub-crates. > > >> > > > > >> > &g

Re: [Rust] crate versions and release process

2019-01-06 Thread Uwe L. Korn
32 AM Kouhei Sutou > >wrote: > >> > > > >> > > Hi, > >> > > > >> > > I have no opinion about version of sub-crates. > >> > > > >> > > When should we bump version of sub-crates? Is it a matter of > >> >

Re: [Rust] crate versions and release process

2019-01-06 Thread Marco Neumann
, 2019 at 1:32 AM Kouhei Sutou >wrote: >> > > >> > > Hi, >> > > >> > > I have no opinion about version of sub-crates. >> > > >> > > When should we bump version of sub-crates? Is it a matter of >> > > Rust devel

Re: [Rust] crate versions and release process

2019-01-05 Thread Wes McKinney
> I just want to know whether release managers need to care > > > version of sub-crates or not. > > > > > > > > > Thanks, > > > -- > > > kou > > > > > > In > > > "[Rust] crate versions and release process"

Re: [Rust] crate versions and release process

2019-01-05 Thread Chao Sun
Is it a matter of > > Rust developers rather than release managers? > > > > I just want to know whether release managers need to care > > version of sub-crates or not. > > > > > > Thanks, > > -- > > kou > > > > In > > "[Rus

Re: [Rust] crate versions and release process

2019-01-05 Thread Wes McKinney
a matter of > Rust developers rather than release managers? > > I just want to know whether release managers need to care > version of sub-crates or not. > > > Thanks, > -- > kou > > In > "[Rust] crate versions and release process" on Wed, 2 Jan 2019 21:2

Re: [Rust] crate versions and release process

2019-01-04 Thread Kouhei Sutou
Hi, I have no opinion about version of sub-crates. When should we bump version of sub-crates? Is it a matter of Rust developers rather than release managers? I just want to know whether release managers need to care version of sub-crates or not. Thanks, -- kou In "[Rust] crate ver

Re: [Rust] crate versions and release process

2019-01-04 Thread Marco Neumann
+1 The only thing to keep in mind is that versions are statement regarding API stability (aka semantic versioning). It is easy to forget about these things in a monorepo since you can fix all the breaking changes in the PR they got introduced. So whoever cuts the release must account for that an

Re: [Rust] crate versions and release process

2019-01-04 Thread Krisztián Szűcs
Agree, +1 On Thu, Jan 3, 2019 at 10:49 PM Andy Grove wrote: > +1 from me. Keeping the code in a single repo makes sense but no need to > artificially keep versions numbers consistent between the sub-crates. > > Andy. > > On Wed, Jan 2, 2019 at 10:28 PM Chao Sun wrote: > > > Hi, > > > > This is

Re: [Rust] crate versions and release process

2019-01-03 Thread Andy Grove
+1 from me. Keeping the code in a single repo makes sense but no need to artificially keep versions numbers consistent between the sub-crates. Andy. On Wed, Jan 2, 2019 at 10:28 PM Chao Sun wrote: > Hi, > > This is related to an earlier email I sent regarding separating the Rust > implementatio

[Rust] crate versions and release process

2019-01-02 Thread Chao Sun
Hi, This is related to an earlier email I sent regarding separating the Rust implementation into sub crates. See some early discussions in this PR [1]. As we could have multiple crates for the project in future (e.g., arrow, parquet, orc, gandiva), I'm wondering whether we can keep different vers