I'd echo Wes's broader point and also potentially encourage downstream
projects to run CI against the master branch for catching breakages.
I also think the initial set of recommendations do make sense for some sort
of changes (when code does break APIs so more members can weigh in). Also
formali
When it comes to downstream projects, it may make sense to implement
some integration tests that can be triggered via Crossbow if you
aren't sure whether a change will cause breakage.
On Fri, Jan 29, 2021 at 1:25 PM Andrew Lamb wrote:
>
> Micah, it is a great question.
>
> I often find myself thi
Micah, it is a great question.
I often find myself thinking "is this PR ok to merge" and going by gut feel
of if it has sufficient review and consensus. I think most of the time
these decisions are sound, but at least once it was not (that particular
instance I think has been since sorted satisfac
One of the challenges that we face in the Rust implementation is that some
parts of the project, especially DataFusion, are still moving fast, with
frequent breaking changes, and because there are now multiple projects that
depend on it, we need to be thoughtful about the impact of these changes on
Just curious what is driving the formalization of a policy? Have Rust
contributions been having issues?
We don't have a 2 reviewer requirement for any of the other languages as
far as I know. And committers generally use their judgement if a second
reviewer is necessary.
Same question about lea
Hi,
Thanks a lot for writing. I like it very much.
Some follow ups / clarifications:
Do we differentiate between who PRed? I.e. if it is a committer, do they
count for the approval or in that case do we need 2 approvals? I am more
favourable to require a second approval as usual, with the idea t
Thanks for writing this up, Andrew. I think this looks good.
One challenge for me, and I assume I am not alone, is that I generally only
have time at weekends to review non-trivial PRs.
I don't think there is a good solution to this problem but I will comment
on the PRs that I have a particular i
One of the items that we discussed at Wednesday's Rust sync was "what is
the criteria to merge a Rust PR". There was no conclusion at the meeting,
but there was a proposal which we would like to discuss on the mailing list.
*Goal*: Keep Arrow Rust PRs flowing in a timely fashion, thereby keeping
v
