Re: [Rust] [DataFusion] Proposal for datafusion test reorganization

2021-07-18 Thread Andrew Lamb
I finally had a chance to write this up: https://github.com/apache/arrow-datafusion/issues/743 Sorry that took so long -- most of my open source time recently has been focused on the arrow release process Andrew On Thu, Apr 15, 2021 at 7:05 AM Andrew Lamb wrote: > Thanks Daniël, > > I'll write

Re: [Rust] [DataFusion] Proposal for datafusion test reorganization

2021-04-15 Thread Andrew Lamb
Thanks Daniël, I'll write up a more formal proposal / jira in the upcoming days Andrew On Tue, Apr 13, 2021 at 11:37 AM Daniël Heres wrote: > Late reply, but I agree these tests modules need a bit of reorganization. I > also found myself adding tests to context.rs / sql.rs just because > relat

Re: [Rust] [DataFusion] Proposal for datafusion test reorganization

2021-04-13 Thread Daniël Heres
Late reply, but I agree these tests modules need a bit of reorganization. I also found myself adding tests to context.rs / sql.rs just because related/similar tests are included there. Sounds like a good reorganization to me! On Fri, Apr 9, 2021, 20:44 Andrew Lamb wrote: > As Jorge points out h

[Rust] [DataFusion] Proposal for datafusion test reorganization

2021-04-09 Thread Andrew Lamb
As Jorge points out here [1], the tests in datafusion/src/context.rs are not really unit tests. They are more like SQL integration tests. There is also a small and languishing set of sql tests in `rust/datafusion/tests/ sql.rs`. These tests are critical for DataFusion's quality and I would like to