Re: [Rust][Datafusion] Timestamp Millisecond support

2021-04-18 Thread Andrew Lamb
I think the `to_timestamp_*` sounds like a good idea to me On Sat, Apr 17, 2021 at 3:00 PM Evan Chan wrote: > Andrew and others, > > Thanks for your input. > > > > > 3. For functions (e.g. date_trunc(...)), I think the infrastructure for > > multiple type signatures exists, we just need implemen

Re: [Rust][Datafusion] Timestamp Millisecond support

2021-04-17 Thread Evan Chan
Andrew and others, Thanks for your input. > > 3. For functions (e.g. date_trunc(...)), I think the infrastructure for > multiple type signatures exists, we just need implementations for different > resolutions Sure, we can add more type support in date_trunc() and other functions. > 4. For con

Re: [Rust][Datafusion] Timestamp Millisecond support

2021-04-16 Thread Andrew Lamb
Hi Evan, Thank you for writing this up. For anyone else following along, there is more context / background on [1] I personally like the "- Add support for functions to work with different timestamp types" option; In my mind this would effectively mean promoting the other timestamp types to be "f

[Rust][Datafusion] Timestamp Millisecond support

2021-04-15 Thread Evan Chan
Hi folks, So currently Arrow Rust/DataFusion supports four types of Timestamp arrays, with Nano, Micro, Millisecond and Second resolution. However, the best supported by far are Nanos. For example, in DataFusion, the following only works for Nanos and not the other resolutions: * CAST(x as TI