Thanks Weston!
> @Andrew What does "waiting for review" mean to you? Does "no existing
> reviewers and passes checks" sound reasonable?
Yes those and "not a draft PR"
> Is there a distinction between "never reviewed and ready" and "has been
reviewed but review is re-requested"?
Not for me -- o
So I took some time to look this over today and consider the
possibilities. I also explored the basic capabilities available from
Github more and learned a few tricks and capabilities that I didn't
realize existed.
@Wes I'm not sure how the Spark dashboard is helpful. This may be a
case of simpl
@Weston: Adding a system to figure out when PRs are waiting for review
would really help me personally. I spend non trivial time trying to make
sure we don't miss any Rust PRs that come in and it gets challenging to
filter out the ones that are WIP.
Having a bot add some labels would be great.
@N
Are non-committers able to add/remove tags to PRs? Sounds like a good way
to increase visibility/searchability of PRs needing review, but it would
only work if everyone is authorized to modify tags.
Neal
On Sun, Mar 7, 2021 at 12:24 PM Wes McKinney wrote:
> This sounds like a nice idea as long
This sounds like a nice idea as long as the bot doesn't generate too
much potentially spurious info (i.e. the "needs improvement" label
when it perhaps need not).
Note that the Spark community set up a pretty handy PR dashboard
https://spark-prs.appspot.com
It's open source: https://github.com/d
Since we're on the topic of improving the workflow I had a proposal to
consider. Right now the review process is pretty ad-hoc which is fine
but can be a bit tricky to keep track of.
I think it could be improved with a bot to label PRs. The labels would be...
state: failing tests - Any PR start
