Re: [JS] BigNum toJSON returns a string with quotations in it

2020-10-28 Thread Paul Taylor
or > Sent: Wednesday, October 28, 2020 8:05 AM > To: dev@arrow.apache.org > Subject: Re: [JS] BigNum toJSON returns a string with quotations in it > > External Email: Use caution with links and attachments > > > Yes, the quotes should be removed. > > I'd recommend

RE: [JS] BigNum toJSON returns a string with quotations in it

2020-10-28 Thread Lee, David
esday, October 28, 2020 8:05 AM To: dev@arrow.apache.org Subject: Re: [JS] BigNum toJSON returns a string with quotations in it External Email: Use caution with links and attachments Yes, the quotes should be removed. I'd recommend using the binary IPC format to send data to the browser tho

Re: [JS] BigNum toJSON returns a string with quotations in it

2020-10-28 Thread Paul Taylor
Yes, the quotes should be removed. I'd recommend using the binary IPC format to send data to the browser though. Deserializing to JSON is expensive, loses the benefits of features like dictionary encoding, and reconstructing types on the receiving end is error-prone (as illustrated here). Paul

[JS] BigNum toJSON returns a string with quotations in it

2020-10-28 Thread Sam Peka
Hi there, The toJSON method of BigNum is currently returning a string with quotation marks around it: https://github.com/apache/arrow/blob/fbb781bcdd15d54c52c71881c5c53d0c68069be6/js/src/util/bn.ts#L39 JSON.stringify will include those quotation marks in the output JSON. Here’s an example illu