Re: [Flight] Question about C++ implementation

2019-04-03 Thread Antoine Pitrou
Hi David, Thanks for the clarification. I agree about not exposing Protobuf in the public API. But it's a pity it forces us to such manual data wrangling... Regards Antoine. Le 03/04/2019 à 17:12, David Li a écrit : > Hi Antoine, > > The ToProto/FromProto methods convert between Protobuf

Re: [Flight] Question about C++ implementation

2019-04-03 Thread David Li
Hi Antoine, The ToProto/FromProto methods convert between Protobuf structs and Flight-specific structs. They aren't actually parsing or serializing anything. While you could argue for just using the Protobuf structs directly, I there are a few reasons not to: - We don't want to expose Protobuf in

[Flight] Question about C++ implementation

2019-04-03 Thread Antoine Pitrou
Hello, Why do we have parsing / unparsing implementations in src/arrow/flight/internal.cc? I assumed gRPC / protobuf would give this to us for free. Instead it seems we have to write it ourselves? Regards Antoine.