Re: [Discuss] Bearer Token refresh design with retry mechanism

2020-11-25 Thread Keerat Singh
Thank you David for the prompt response, I will take a look and respond to them. Regards, Keerat On Wed, Nov 25, 2020 at 11:51 AM David Li wrote: > Hi Kerrat, > > Please see my comments in the doc - I think I commented while this email > went out. I would prefer to just retry on UNAUTHENTICATED

Re: [Discuss] Bearer Token refresh design with retry mechanism

2020-11-25 Thread David Li
Hi Kerrat, Please see my comments in the doc - I think I commented while this email went out. I would prefer to just retry on UNAUTHENTICATED. Also, with gRPC and especially with streaming calls, you may not get an error status right away, as you've found - so there's additional work needed to

Re: [Discuss] Bearer Token refresh design with retry mechanism

2020-11-25 Thread David Li
Having retries seems reasonable to me, I've added some comments on the linked doc. Best, David On Wed, Nov 25, 2020, at 14:18, Wes McKinney wrote: > In principle adding a new error code for this seems reasonable to me. > What do you think about calling it something more generic like > "AUTH_EXPI

Re: [Discuss] Bearer Token refresh design with retry mechanism

2020-11-25 Thread Keerat Singh
Hey Wes, Renaming it to be more generic like AUTH_EXPIRED sounds good to me, updated the design doc. RE: The implementation, while working on the Java POC for this: - Adding it to the FlightStatusCode

Re: [Discuss] Bearer Token refresh design with retry mechanism

2020-11-25 Thread Wes McKinney
In principle adding a new error code for this seems reasonable to me. What do you think about calling it something more generic like "AUTH_EXPIRED"? I haven't looked at the details of the implementation -- David Li or others may be able to provide better comments? On Fri, Nov 20, 2020 at 6:23 PM K

[Discuss] Bearer Token refresh design with retry mechanism

2020-11-20 Thread Keerat Singh
I would like to propose the following enhancement to retry the failed Flight API call and refresh the access token on encountering FlightStatusCode.TOKEN_EXPIRED. For example when using an implementation of CallHeaderAuthenticator