回复:[Discuss][Java] Shading Flatbuffer dependency

2019-06-26 Thread Ji Liu
Thanks for opening the discuss and the proposal, Micah. Looks reasonable to me. Thanks Ji Liu -- 发件人:Micah Kornfield 发送时间:2019年6月26日(星期三) 20:35 收件人:dev@arrow.apache.org 主 题:Re: [Discuss][Java] Shading Flatbuffer dependency There

Re: [Discuss][Java] Shading Flatbuffer dependency

2019-06-26 Thread Micah Kornfield
There is a proposed PR [1] now that shades flatbuffers by consolidating all related code in the vector module and provides wrapping classes upstream for flight. It deletes the format module. Feedback welcome. Thanks, Micah [1] https://github.com/apache/arrow/pull/4701 On Thursday, June 20, 201

[Discuss][Java] Shading Flatbuffer dependency

2019-06-20 Thread Micah Kornfield
ARROW-5579 [1] brought to our attention that the core flat buffer library makes no guarantees of compatibility with generated class files that were generated with a different version. Properly shading the dependency seems to require using the shaded version across all of our sub-project. Ji Liu f