Re: [DISCUSS] Joda Time -> Java8 Time

2019-02-20 Thread Praveen Kumar
Hi Bryan, Sorry about the delay in getting to this. We got around to doing this only recently, one of our engineers is working on this and we will circle back by next Wednesday with the next steps. Thx. On Wed, Feb 20, 2019 at 12:00 PM Bryan Cutler wrote: > Wanted to give this a bump to see if

Re: [DISCUSS] Joda Time -> Java8 Time

2019-02-19 Thread Bryan Cutler
Wanted to give this a bump to see if the timing is better now for the folks at Dremio to take a look at the impact switching to Java 8 Time? PR at https://github.com/apache/arrow/pull/2966 Thanks, Bryan On Tue, Nov 20, 2018 at 10:41 PM Praveen Kumar wrote: > Jacques, > > Shyam is trying to buil

Re: [DISCUSS] Joda Time -> Java8 Time

2018-11-20 Thread Praveen Kumar
Jacques, Shyam is trying to build dremio against the patch to assess impact. Will keep the list posted as we progress. Thx. On Fri, Nov 16, 2018 at 9:46 AM Jacques Nadeau wrote: > I'm worried about the change from Millis to Nanos. It seems not so good. I > think we (dremio) need to better unde

Re: [DISCUSS] Joda Time -> Java8 Time

2018-11-15 Thread Jacques Nadeau
I'm worried about the change from Millis to Nanos. It seems not so good. I think we (dremio) need to better understand impact. Praveen, maybe you could take a look at impact? On Wed, Nov 14, 2018, 4:27 PM Bryan Cutler Hi all, > > I'm picking this back up again and have WIP pr at > https://github.

Re: [DISCUSS] Joda Time -> Java8 Time

2018-11-14 Thread Bryan Cutler
Hi all, I'm picking this back up again and have WIP pr at https://github.com/apache/arrow/pull/2966. Please take a look at the new APIs and see if they impact you downstream. In addition to the API changes mentioned before by Li, there is also (4) IntervalDayVector now uses java.time.Duration, w

Re: [DISCUSS] Joda Time -> Java8 Time

2018-06-28 Thread Li Jin
I did a grep of "joda" in the java vector codebase. The current reference to joda includes: (1) auto-generated reader class under arrow/vector/complex/impl and arrow/vector/complex/reader These class currently have API that returns joda classes, e.g.: NullableTimestampMicroHolderReaderImpl: //

Re: [DISCUSS] Joda Time -> Java8 Time

2018-06-28 Thread Jacques Nadeau
Can we get a proposed listing of apis that would change? Definitely will be effort for people like us to rewrite all code to use different items. On Wed, Jun 27, 2018 at 10:54 AM, Li Jin wrote: > Hi, > > There has been a recent pr 2171 for ARROW-2015 to replace Joda time with > Java8 time. > > I

[DISCUSS] Joda Time -> Java8 Time

2018-06-27 Thread Li Jin
Hi, There has been a recent pr 2171 for ARROW-2015 to replace Joda time with Java8 time. I think this change is good as we move toward newer Java version and wonder if we should include this in the 0.10 release. The biggest concern is that this is a breaking change and could impact downstream pr