Re: [DISCUSS] Fix Arrow Flight Core tests

2023-12-15 Thread Jean-Baptiste Onofré
docs/developers/java/building.html > is for building checked out repository instead of a release > source archive. > > Thanks, > -- > kou > > In > "Re: [DISCUSS] Fix Arrow Flight Core tests" on Wed, 13 Dec 2023 20:42:29 > +0100, > Jean-Baptiste Onofr

Re: [DISCUSS] Fix Arrow Flight Core tests

2023-12-13 Thread Sutou Kouhei
Hi, I think (2) is better because https://arrow.apache.org/docs/developers/java/building.html is for building checked out repository instead of a release source archive. Thanks, -- kou In "Re: [DISCUSS] Fix Arrow Flight Core tests" on Wed, 13 Dec 2023 20:42:29 +0100, Jean-Bapti

Re: [DISCUSS] Fix Arrow Flight Core tests

2023-12-13 Thread Jean-Baptiste Onofré
That's my point: 1. we should document that the build has to be launched with -DskipTests by default 2. or include submodule in the source distribution we distributed I think (1) is an acceptable and easy path. If there are no objections, I will create a PR about that (also updating https://arrow.

Re: [DISCUSS] Fix Arrow Flight Core tests

2023-12-13 Thread David Li
Could we include submodules in the source distribution instead? Also, you can still build from the source distribution, you just have to -DskipTests. On Wed, Dec 13, 2023, at 09:54, Jean-Baptiste Onofré wrote: > Hi David and foxes, > > I checked the release source distribution and I think we sh

Re: [DISCUSS] Fix Arrow Flight Core tests

2023-12-13 Thread Jean-Baptiste Onofré
Hi David and foxes, I checked the release source distribution and I think we should maybe include a profile to include TestTls related tests. As an Apache project, we are supposed to be able to build from the source distribution without any external requirements (in the case the project goes to t

Re: [DISCUSS] Fix Arrow Flight Core tests

2023-12-11 Thread Jean-Baptiste Onofré
Thanks David, Good point. Let me create a PR to point to this when the pem is not found. Regards JB On Mon, Dec 11, 2023 at 3:00 PM David Li wrote: > > You can `git submodule update --init` to get the files. This is documented in > the environment setup [1], though the failing assertion could

Re: [DISCUSS] Fix Arrow Flight Core tests

2023-12-11 Thread David Li
You can `git submodule update --init` to get the files. This is documented in the environment setup [1], though the failing assertion could be more helpful about pointing this out. [1]: https://arrow.apache.org/docs/dev/developers/java/building.html#building On Mon, Dec 11, 2023, at 08:49, Jean

[DISCUSS] Fix Arrow Flight Core tests

2023-12-11 Thread Jean-Baptiste Onofré
Hi guys, I noticed that Arrow Flight Core doesn't build "out of the box" due to the TestTls failing. The reason what TestTls is failing is because it tries to read cert0.pem from the testing/data folder (at project root), but testing is empty by default. If I create a cert0.pem by hand (with self