Re: [DISCUSS] Dropping support for Visual Studio 2015

2021-08-14 Thread Uwe L. Korn
+1 VS2017 should also be compatible with VS2015 so that this should cause any issues for downstream users that link dynamically. > Am 14.08.2021 um 01:56 schrieb Benjamin Kietzman : > > Thanks for commenting, all. I'll open a JIRA/PR to remove support next week. > >> On Tue, Aug 10, 2021, 09

Re: [DISCUSS] Dropping support for Visual Studio 2015

2021-08-13 Thread Benjamin Kietzman
Thanks for commenting, all. I'll open a JIRA/PR to remove support next week. On Tue, Aug 10, 2021, 09:34 Wes McKinney wrote: > +1 for dropping it also. > > On Mon, Aug 9, 2021 at 7:03 PM Keith Kraus > wrote: > > > > +1 as well. Is there any build platforms that we're currently supporting > > th

Re: [DISCUSS] Dropping support for Visual Studio 2015

2021-08-10 Thread Wes McKinney
+1 for dropping it also. On Mon, Aug 9, 2021 at 7:03 PM Keith Kraus wrote: > > +1 as well. Is there any build platforms that we're currently supporting > that still use vs2015? > > Conda-forge did its migration ~1.5 years ago: > https://github.com/conda-forge/conda-forge-pinning-feedstock/pull/50

Re: [DISCUSS] Dropping support for Visual Studio 2015

2021-08-09 Thread Keith Kraus
+1 as well. Is there any build platforms that we're currently supporting that still use vs2015? Conda-forge did its migration ~1.5 years ago: https://github.com/conda-forge/conda-forge-pinning-feedstock/pull/501. -Keith On Mon, Aug 9, 2021 at 12:01 PM Antoine Pitrou wrote: > > +1 for requiring

Re: [DISCUSS] Dropping support for Visual Studio 2015

2021-08-09 Thread Antoine Pitrou
+1 for requiring a more recent MSVC version. Regards Antoine. Le 09/08/2021 à 17:38, Benjamin Kietzman a écrit : MSVC 19.0 is buggy enough that I for one have spent multiple days reworking code that is fine for all other compilers we test against. Most recently in the context of https://git

[DISCUSS] Dropping support for Visual Studio 2015

2021-08-09 Thread Benjamin Kietzman
MSVC 19.0 is buggy enough that I for one have spent multiple days reworking code that is fine for all other compilers we test against. Most recently in the context of https://github.com/apache/arrow/pull/10793 (ARROW-13482) I found that for some types T, `std::is_convertible::value` will be false.