Re: [C++] [Compute] Question on "EVENT" macro in ExecNode

2022-04-19 Thread Li Jin
Thanks! This is helpful. Will take a look. On Tue, Apr 19, 2022 at 7:00 PM Weston Pace wrote: > I can't speak for others but I do normal development with a debug > build & UBSAN turned on. I haven't had any problems using gdb in this > setup. Usually if I get a release-only bug it's because of

Re: [C++] [Compute] Question on "EVENT" macro in ExecNode

2022-04-19 Thread Weston Pace
I can't speak for others but I do normal development with a debug build & UBSAN turned on. I haven't had any problems using gdb in this setup. Usually if I get a release-only bug it's because of timing or memory being reused more aggressively in which case I would at least start with ASAN and TSA

Re: [C++] [Compute] Question on "EVENT" macro in ExecNode

2022-04-19 Thread Li Jin
I see. Thanks Weston. This is a nice tracing utils. I will give it a shot. Although it might be more information that I actually want, I might just use a print statement. As a side question - what do most of Arrow dev use for debugging compute related code? I am new to this and tried to pdb but en

Re: [C++] [Compute] Question on "EVENT" macro in ExecNode

2022-04-19 Thread Weston Pace
The EVENT macro is specific to open telemetry tracing. So if `side` is only used to populate the event then I think you will need to surround the entire block with: ``` #ifdef ARROW_WITH_OPENTELEMETRY int side = ... EVENT(span_, "InputReceived", {{"batch.length", batch.length}, {"side", side}});

[C++] [Compute] Question on "EVENT" macro in ExecNode

2022-04-19 Thread Li Jin
Hello! I am trying to implement a new type of join in Arrow Compute engine (asof join). I have been looking at code of HashJoinNode and found some debug code that seems to be useful: e.g.: EVENT(span_, "InputReceived", {{"batch.length", batch.length}, {"side", side}}); But when I try to use