Re: Nested data support?

2018-11-09 Thread Joshua Storck
I hope to get around to finishing my PR for reading in the next month or so. The work is mostly complete, it's just that it didn't get merged before the monorepo consolidation. I expect the write side of things to be easier, though it will probably take a month or so of work with testing. On Fri,

Re: [DISCUSS] Solutions for improving the Arrow-Parquet C++ development morass

2018-07-30 Thread Joshua Storck
ink experience has clearly demonstrated that the current > separation is impractical, and is causing problems. > > Per Julian's and Ted's comments, I think we need to consider > development process and ASF releases separately. My argument is as > follows: > > * Monorepo

Re: [DISCUSS] Solutions for improving the Arrow-Parquet C++ development morass

2018-07-30 Thread Joshua Storck
I recently worked on an issue that had to be implemented in parquet-cpp (ARROW-1644, ARROW-1599) but required changes in arrow (ARROW-2585, ARROW-2586). I found the circular dependencies confusing and hard to work with. For example, I still have a PR open in parquet-cpp (created on May 10) because

Re: C++: Covariant Return Types for Array::type()

2018-05-19 Thread Joshua Storck
> > On Sat, May 19, 2018 at 1:53 PM, Joshua Storck > wrote: > > I've updated the document with an extra section to include code snippets > > for alternative designs to address concerns raised here on the mailing > list. > > Thanks, I will look in more detail a

Re: C++: Covariant Return Types for Array::type()

2018-05-19 Thread Joshua Storck
May 19, 2018 at 5:37 PM, Wes McKinney wrote: > hi Josh, > > On Sat, May 19, 2018 at 1:53 PM, Joshua Storck > wrote: > > I've updated the document with an extra section to include code snippets > > for alternative designs to address concerns raised here on the mailin

Re: C++: Covariant Return Types for Array::type()

2018-05-19 Thread Joshua Storck
I've updated the document with an extra section to include code snippets for alternative designs to address concerns raised here on the mailing list. MSVC 19 2017 supports covariant return types, and the code presented above successfully compiled on gcc.godbolt.org using that compiler. I would ag

[jira] [Created] (ARROW-2586) Make child builders of ListBuilder and StructBuilder shared_ptr's

2018-05-15 Thread Joshua Storck (JIRA)
Joshua Storck created ARROW-2586: Summary: Make child builders of ListBuilder and StructBuilder shared_ptr's Key: ARROW-2586 URL: https://issues.apache.org/jira/browse/ARROW-2586 Project: A

[jira] [Created] (ARROW-2585) Add Decimal128::FromBigEndian

2018-05-15 Thread Joshua Storck (JIRA)
Joshua Storck created ARROW-2585: Summary: Add Decimal128::FromBigEndian Key: ARROW-2585 URL: https://issues.apache.org/jira/browse/ARROW-2585 Project: Apache Arrow Issue Type: Improvement

[jira] [Created] (ARROW-2497) Use ASSERT_NO_FATAIL_FAILURE in C++ unit tests

2018-04-23 Thread Joshua Storck (JIRA)
Joshua Storck created ARROW-2497: Summary: Use ASSERT_NO_FATAIL_FAILURE in C++ unit tests Key: ARROW-2497 URL: https://issues.apache.org/jira/browse/ARROW-2497 Project: Apache Arrow Issue