+1
Thanks Kou!
On Mon, Apr 24, 2023, at 11:53, Sutou Kouhei wrote:
> +1
>
> In <20230424.103259.664806138128874521@clear-code.com>
> "[VOTE] Formalize how to change format" on Mon, 24 Apr 2023 10:32:59
> +0900 (JST),
> Sutou Kouhei wrote:
>
>> Hi,
>>
>> I would like to formalize how to
Hi, thanks for all your great suggestions.
Seems like we are having an alignment on adding a codec::options class instead
of passing extra parameters in existing function calls. A virtual base class
with derived classes sounds like a good idea to add specific codec options for
different codecs
+1
In <20230424.103259.664806138128874521@clear-code.com>
"[VOTE] Formalize how to change format" on Mon, 24 Apr 2023 10:32:59 +0900
(JST),
Sutou Kouhei wrote:
> Hi,
>
> I would like to formalize how to change format process.
>
> See the following pull request and discussion for detai
Hi,
I would like to formalize how to change format process.
See the following pull request and discussion for details:
* GH-35084: [Docs][Format] Add how to change format specification
https://github.com/apache/arrow/pull/35174
Preview: http://crossbow.voltrondata.com/pr_docs/35174/format/C
Hi,
It seems that we have no more comments for this.
I'll start a vote for this.
Thanks,
--
kou
In <20230420.091259.902242694352936494@clear-code.com>
"Re: [DISCUSS] Formalize how to change format" on Thu, 20 Apr 2023 09:12:59
+0900 (JST),
Sutou Kouhei wrote:
> Hi,
>
> Here is the
+1 (non binding)
I have tested both SOURCES and BINARIES successfully with:
TEST_DEFAULT=0 TEST_SOURCE=1 dev/release/verify-release-candidate.sh 12.0.0 0
TEST_DEFAULT=0 TEST_WHEELS=1 dev/release/verify-release-candidate.sh 12.0.0 0
TEST_DEFAULT=0 TEST_BINARIES=1 dev/release/verify-release-candidat
The most idiomatic option seems to be a virtual base class with derived
classes as required:
```
class CodecOptions {
public:
virtual ~CodecOptions() = default;
int compression_level;
};
class ZlibCodecOptions : public CodecOptions {
public:
~CodecOptions() = default;
int window_
It is a good idea to extend the Codec factory to offer more options.
However, I don't think adding
a `window_bits` parameter as `compression_level` is a good approach as it
does not apply to
some codecs.
IMO, the proposed new `Codec::Options` can be as simple as a
std::map.
To avoid misuse, we nee
On 2023/04/23 09:38:02 "Yang, Yang10" wrote:
> Hi,
>
> As discussed in this issue: https://github.com/apache/arrow/issues/35287,
currently Arrow only supports one parameter: compression_level to be
customized. We would like to make more compression parameters (such as
window_bits) customizable when
+1
I ran the followings on Ubuntu-22.04, aarch64.
TEST_DEFAULT=0 \
TEST_CPP=1 \
TEST_PYTHON=1 \
TEST_GO=1 \
dev/release/verify-release-candidate.sh 12.0.0 0
TEST_DEFAULT=0 \
TEST_WHEELS=1 \
dev/release/verify-release-candidate.sh 12.0.0 0
On 4/23/23 14:40, Sutou Kouhei wrote:
+1
Hi,
As discussed in this issue: https://github.com/apache/arrow/issues/35287,
currently Arrow only supports one parameter: compression_level to be
customized. We would like to make more compression parameters (such as
window_bits) customizable when creating the Codec, given the variety of usage
11 matches
Mail list logo
