Re: [VOTE][RUST][DataFusion] Release DataFusion Python Bindings 21.0.0 RC1

2023-03-31 Thread Jacob Wujciak
I attempted to install via pip but 21.0.0 is not on test.pypi.org, the most recent version there is 0.7.0 On Fri, Mar 31, 2023 at 9:17 PM Jeremy Dyer wrote: > +1 (non-binding) validate local conda build (not via verify script), hashes > for artifacts, and ran verification script. LGTM. Thanks fo

Re: Proposal: add a bot to close PRs that haven't been updated in 30 days

2023-03-31 Thread Jacob Wujciak
I am +1 on the general idea. Looking at other projects a two step process with the PRs being marked stale first (with a comment to ping participants) and only being closed after a second period of time. I also agree with Rok that it would be nice to do /something/ with the issue backlog. There are

Re: [VOTE][RUST] Release Apache Arrow Rust Object Store 0.5.6 RC2

2023-03-31 Thread Jacob Wujciak
+1 (non-binding) verified on manjaro On Fri, Mar 31, 2023 at 10:00 PM Raphael Taylor-Davies wrote: > Thank you for double checking, ApplicationDefaultCredentialsFile is in a > crate private module and isn't re-exported, so we should be good. > > > > On 31 March 2023 20:16:29 BST, Andrew Lamb wr

Re: [ANNOUNCE] New Arrow committer: Mustafa Akur

2023-03-31 Thread Jacob Wujciak
Congrats! On Sat, Apr 1, 2023 at 12:42 AM Raúl Cumplido wrote: > Congratulations Mustafa! > > El vie, 31 mar 2023, 22:01, Rok Mihevc escribió: > > > Congrats! > > > > Rok > > > > On Fri, Mar 31, 2023 at 9:42 PM Mehmet Ozan Kabak > wrote: > > > > > Congrats Mustafa! You are a great team member

Re: [ANNOUNCE] New Arrow committer: Mustafa Akur

2023-03-31 Thread Raúl Cumplido
Congratulations Mustafa! El vie, 31 mar 2023, 22:01, Rok Mihevc escribió: > Congrats! > > Rok > > On Fri, Mar 31, 2023 at 9:42 PM Mehmet Ozan Kabak wrote: > > > Congrats Mustafa! You are a great team member at Synnada and I’m sure you > > will be a valued member of the Apache Arrow community to

Re: [ANNOUNCE] New Arrow committer: Mustafa Akur

2023-03-31 Thread Rok Mihevc
Congrats! Rok On Fri, Mar 31, 2023 at 9:42 PM Mehmet Ozan Kabak wrote: > Congrats Mustafa! You are a great team member at Synnada and I’m sure you > will be a valued member of the Apache Arrow community too. > > > On Mar 31, 2023, at 10:54 AM, Matthew Topol > wrote: > > > > Congrats Mustafa! W

Re: [VOTE][RUST] Release Apache Arrow Rust Object Store 0.5.6 RC2

2023-03-31 Thread Raphael Taylor-Davies
Thank you for double checking, ApplicationDefaultCredentialsFile is in a crate private module and isn't re-exported, so we should be good. On 31 March 2023 20:16:29 BST, Andrew Lamb wrote: >+1 (verified on mac x86) > >I took a look through the PRs -- I think [1] is actually SemVer but I >wan

Re: Proposal: add a bot to close PRs that haven't been updated in 30 days

2023-03-31 Thread Rok Mihevc
I agree with Joris' and David's points here and would prefer some form of pinging. Also at 120 open PRs we could realistically close out stale ones manually. Meanwhile we have 3.2k open issues where we might want to get creative. Rok On Fri, Mar 31, 2023 at 9:17 PM Antoine Pitrou wrote: > > I

Re: [ANNOUNCE] New Arrow committer: Mustafa Akur

2023-03-31 Thread Mehmet Ozan Kabak
Congrats Mustafa! You are a great team member at Synnada and I’m sure you will be a valued member of the Apache Arrow community too. > On Mar 31, 2023, at 10:54 AM, Matthew Topol > wrote: > > Congrats Mustafa! Welcome! > > On Fri, Mar 31, 2023 at 9:24 AM David Li wrote: > >> Congrats & welc

Re: [VOTE][RUST][DataFusion] Release DataFusion Python Bindings 21.0.0 RC1

2023-03-31 Thread Jeremy Dyer
+1 (non-binding) validate local conda build (not via verify script), hashes for artifacts, and ran verification script. LGTM. Thanks for the release Andy! - Jeremy Dyer On Fri, Mar 31, 2023 at 12:06 PM Andy Grove wrote: > Hi, > > I would like to propose a release of Apache Arrow DataFusion Pyth

Re: [VOTE][RUST] Release Apache Arrow Rust Object Store 0.5.6 RC2

2023-03-31 Thread Andrew Lamb
+1 (verified on mac x86) I took a look through the PRs -- I think [1] is actually SemVer but I wanted to double check (to see if we needed to make the version 0.6.0 🤔) The ::new() constructor is the same, but ApplicationDefaultCredentialsFile went from a struct to enum [1] https://github.com/a

Re: Proposal: add a bot to close PRs that haven't been updated in 30 days

2023-03-31 Thread Antoine Pitrou
I have the same opinion as Joris. We shouldn't auto-close PRs simply because they have not been recently updated. For a casual contributor it can be extremely frustrating and demotivating to be dealt such a treatment, especially if you've already found it difficult to attract the attention o

Re: [External] Re: row counts in footer of IPC file format

2023-03-31 Thread David Dali Susanibar Arce
Hi Team, Hi Martin, could be a good input to validate if this new Java functionality is already implemented in other languages like C++ to consider that as a must-have, also to check how it is aligned with your current implementation. Anyway, I'm really interested in the PR review. Related to row

Re: [VOTE][RUST] Release Apache Arrow Rust Object Store 0.5.6 RC2

2023-03-31 Thread L. C. Hsieh
Oh, I verified RC1 wrongly. Then for RC2, +1 (binding) Verified on M1 Mac. Thanks Raphael. On Fri, Mar 31, 2023 at 10:34 AM Raphael Taylor-Davies wrote: > > Are you verifying RC1 or RC2? RC1 had the issue you mention > > On 31/03/2023 18:17, L. C. Hsieh wrote: > > Hmm, I got an error like fo

Re: [VOTE][RUST] Release Apache Arrow Rust Object Store 0.5.6 RC2

2023-03-31 Thread Raphael Taylor-Davies
Are you verifying RC1 or RC2? RC1 had the issue you mention On 31/03/2023 18:17, L. C. Hsieh wrote: Hmm, I got an error like following on both M1 and Intel Macs. ``` + cargo build error: failed to parse manifest at `/private/var/folders/zq/2tdnn5955wvdcw7qfy6qhvk0gn/T/arrow-0.5.6.X.VnN

Re: [VOTE][RUST] Release Apache Arrow Rust Object Store 0.5.6 RC2

2023-03-31 Thread L. C. Hsieh
Hmm, I got an error like following on both M1 and Intel Macs. ``` + cargo build error: failed to parse manifest at `/private/var/folders/zq/2tdnn5955wvdcw7qfy6qhvk0gn/T/arrow-0.5.6.X.VnNkJPdg/apache-arrow-object-store-rs-0.5.6/Cargo.toml` Caused by: error inheriting `edition` from wo

Re: Proposal: add a bot to close PRs that haven't been updated in 30 days

2023-03-31 Thread Weston Pace
I just now caught up to the recent wave of closed PRs in my notifications so maybe I see where some of this discussion is coming from :) I agree with everything David said and will change my stance from neutral to -0.5. My main problem is that I see no advantage to closing these PRs. On Fri, Mar

Re: Proposal: add a bot to close PRs that haven't been updated in 30 days

2023-03-31 Thread David Li
I think I'm -0.5 overall. I do think it is worthwhile giving a "final chance" ping to very stale PRs as has been suggested, and pinging reviewers for PRs that have been sitting around. Automatically closing PRs purely based on time (since last update) is quite unfriendly. If the problem is rev

Re: [VOTE][RUST][DataFusion] Release DataFusion Python Bindings 21.0.0 RC1

2023-03-31 Thread L. C. Hsieh
+1 (binding) Verified on M1 Mac. Thanks Andy. On Fri, Mar 31, 2023 at 9:06 AM Andy Grove wrote: > > Hi, > > I would like to propose a release of Apache Arrow DataFusion Python > Bindings, > version 21.0.0. > > This release candidate is based on commit: > 48f759b5355d4f7ceeb46b615252e62fb55d0d3a

Re: Proposal: add a bot to close PRs that haven't been updated in 30 days

2023-03-31 Thread Gang Wu
>From a contributor perspective, it would be great if a bot could detect a PR is waiting for review for a certain period of time and then automatically notify reviewers if possible. On Sat, Apr 1, 2023 at 12:21 AM Joris Van den Bossche < jorisvandenboss...@gmail.com> wrote: > On Fri, 31 Mar 202

Re: Proposal: add a bot to close PRs that haven't been updated in 30 days

2023-03-31 Thread Joris Van den Bossche
On Fri, 31 Mar 2023 at 17:38, Alessandro Molina wrote: > > .. > My question probably would be... If a PR was sitting ignored for 30 days > without anyone from the community feeling the need to review and merge it > and without its primary author feeling the need to push for getting it > merged. Is

[VOTE][RUST][DataFusion] Release DataFusion Python Bindings 21.0.0 RC1

2023-03-31 Thread Andy Grove
Hi, I would like to propose a release of Apache Arrow DataFusion Python Bindings, version 21.0.0. This release candidate is based on commit: 48f759b5355d4f7ceeb46b615252e62fb55d0d3a [1] The proposed release tarball and signatures are hosted at [2]. The changelog is located at [3]. The Python whee

Re: Proposal: add a bot to close PRs that haven't been updated in 30 days

2023-03-31 Thread Weston Pace
Personally, my workflow is driven entirely by notifications so I don't even notice stale PRs. That being said, making a PR a draft sounds pretty harmless. Slightly unrelated, but now that we have the "awaiting review" label, would it be possible to write a comment on PRs that have been waiting fo

Re: [ANNOUNCE] New Arrow committer: Mustafa Akur

2023-03-31 Thread Matthew Topol
Congrats Mustafa! Welcome! On Fri, Mar 31, 2023 at 9:24 AM David Li wrote: > Congrats & welcome Mustafa! > > On Fri, Mar 31, 2023, at 06:21, Andrew Lamb wrote: > > Hello Arrow Community > > > > On behalf of the Arrow PMC, I'm happy to announce that Mustafa Akur > > has accepted an invitation to

Re: Proposal: add a bot to close PRs that haven't been updated in 30 days

2023-03-31 Thread Alessandro Molina
I think that marking them drafts could be a good way to reduce the overload for people having to review PRs, drafts can easily be filtered out in github searches. > I am personally not a huge fan of auto-closing PRs. Especially not > after a short period like 30 days (I think that's too short for

Re: Proposal: add a bot to close PRs that haven't been updated in 30 days

2023-03-31 Thread Aldrin
I have some PRs that have been open for awhile and I changed them to be draft PRs (I think that makes them clutter fewer views while I leave them open). I'm just curious if draft PRs are as low cost (low cognitive load) as I think they are and if instead of closing them the bot can make a PR a dra

Re: [VOTE][RUST] Release Apache Arrow Rust Object Store 0.5.6 RC2

2023-03-31 Thread Will Jones
+1 Verified on M1 MacOS. On Fri, Mar 31, 2023 at 4:29 AM Raphael Taylor-Davies wrote: > Hi, > > I would like to propose a release of Apache Arrow Rust Object > Store Implementation, version 0.5.6. > > This release candidate is based on commit: > 234b7847ecb737e96df3f4623df7b330b34b3d1b [1] > >

Re: Proposal: add a bot to close PRs that haven't been updated in 30 days

2023-03-31 Thread Will Jones
> Also good to know: contributors apparently can't re-open PRs if it was > closed by someone else, so we have to be careful with messages like > "feel free to reopen". Thanks for bringing this up, Joris. That does make closing via bot much less appealing to me. I like your idea of (1) having the

Re: [ANNOUNCE] New Arrow committer: Mustafa Akur

2023-03-31 Thread David Li
Congrats & welcome Mustafa! On Fri, Mar 31, 2023, at 06:21, Andrew Lamb wrote: > Hello Arrow Community > > On behalf of the Arrow PMC, I'm happy to announce that Mustafa Akur > has accepted an invitation to become a committer on Apache > Arrow. Welcome, and thank you for your contributions! > > An

Re: [RUST] Somewhat regular sync today

2023-03-31 Thread Andrew Lamb
Thank you -- this is a great idea Will. It is almost time to write another quarterly wrapup / update for DataFusion[1]. This is probably good content to include in that post. I have filed a ticket[2] to track writing a new blog. [1] https://arrow.apache.org/blog/2023/01/19/datafusion-16.0.0/ [2

[VOTE][RUST] Release Apache Arrow Rust Object Store 0.5.6 RC2

2023-03-31 Thread Raphael Taylor-Davies
Hi, I would like to propose a release of Apache Arrow Rust Object Store Implementation, version 0.5.6. This release candidate is based on commit: 234b7847ecb737e96df3f4623df7b330b34b3d1b [1] The proposed release tarball and signatures are hosted at [2]. The changelog is located at [3]. Plea

Re: Proposal: add a bot to close PRs that haven't been updated in 30 days

2023-03-31 Thread Joris Van den Bossche
I am personally not a huge fan of auto-closing PRs. Especially not after a short period like 30 days (I think that's too short for an open source project), and we have to be careful with messaging. Very often such a PR is "stale" because it is waiting for reviews. I know we have the labels now that

[ANNOUNCE] New Arrow committer: Mustafa Akur

2023-03-31 Thread Andrew Lamb
Hello Arrow Community On behalf of the Arrow PMC, I'm happy to announce that Mustafa Akur has accepted an invitation to become a committer on Apache Arrow. Welcome, and thank you for your contributions! Andrew